Skip to content

Update Fleet-maintained apps - #46238

Merged
allenhouchins merged 1 commit into
mainfrom
fma-2605270023
May 27, 2026
Merged

Update Fleet-maintained apps#46238
allenhouchins merged 1 commit into
mainfrom
fma-2605270023

Conversation

@fleet-release

@fleet-release fleet-release commented May 27, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated application metadata for 14 maintained apps to support newer versions, including Bruno, Claude, Discord, GitHub Desktop, Granola, Microsoft Outlook, Notion, OpenVPN Connect, Slack, Tableau, Thunderbird, and Webex across macOS and Windows platforms.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/bruno/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/claude/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/discord/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/github-desktop/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/granola/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/microsoft-outlook/darwin.json

=== Install // ffaf9fe6 -> 0e4e4b82 ===

--- /tmp/old.pQ4Ki4	2026-05-27 00:27:19.832848968 +0000
+++ /tmp/new.EWVh5I	2026-05-27 00:27:19.833848966 +0000
@@ -117,6 +117,6 @@
 
 EOF
 
-sudo installer -pkg "$TMPDIR"/Microsoft_Outlook_16.109.26051717_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
+sudo installer -pkg "$TMPDIR"/Microsoft_Outlook_16.109.26052523_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
 
 relaunch_application 'com.microsoft.Outlook'

=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/notion/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/openvpn-connect/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/slack/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/slack/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/tableau/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/thunderbird/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/thunderbird/windows.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/webex/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request updates maintained-app metadata for 14 applications across macOS and Windows platforms. The changes include version bumps, updated installer download URLs, and refreshed SHA-256 checksums for each application. Most updates follow the same pattern: the version field is incremented, the queries.patched SQL condition is adjusted to compare against the new version, and the installer_url and sha256 fields are replaced with values corresponding to the new installer artifacts. The Microsoft Outlook macOS entry includes an additional change where the install_script_ref is switched from ffaf9fe6 to 0e4e4b82, which alters the installation behavior from an installer-based approach to a package cleanup and removal approach.

Possibly related PRs

  • fleetdm/fleet#44337: Updates to ee/maintained-apps/outputs/microsoft-outlook/darwin.json including version, queries.patched, installer_url, sha256, and associated install_script_ref changes.
  • fleetdm/fleet#45071: Updates to Thunderbird maintained-app manifests (ee/maintained-apps/outputs/thunderbird/darwin.json and ee/maintained-apps/outputs/thunderbird/windows.json) bumping version and synchronizing the queries.patched version gate plus installer_url and sha256.
  • fleetdm/fleet#46037: Fleet-maintained app metadata refresh updating version-specific fields (version, queries.patched thresholds, installer_url, sha256) in the same manifest files.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and vague. It only states 'Automated ingestion of latest Fleet-maintained app data' without following the template structure or providing required details like related issues, checklist items, testing information, or migration notes. Add a detailed description following the repository template, including related issue number, completed checklist items, testing verification, and any relevant notes about the automated changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Fleet-maintained apps' accurately summarizes the main change: updating metadata for multiple Fleet-maintained applications to newer versions across multiple platforms.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605270023

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/microsoft-outlook/darwin.json`:
- Around line 4-7: The JSON incorrectly raises a “version downgrade” concern
even though no 16.109.1 entry exists and the summary misattributes cleanup
actions to the installer; remove the downgrade claim related to "16.109.1" (keep
"version": "16.109" as the single source), and update the summary text to
correctly state that install_script_ref 0e4e4b82 installs
Microsoft_Outlook_16.109...Installer.pkg and relaunches the app while
uninstall_script_ref 36c26399 performs the launchctl/receipt cleanup.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: da49e957-d2f5-40e1-b538-bcfde533e0c7

📥 Commits

Reviewing files that changed from the base of the PR and between 5b2427d and 87e5404.

📒 Files selected for processing (14)
  • ee/maintained-apps/outputs/bruno/darwin.json
  • ee/maintained-apps/outputs/claude/windows.json
  • ee/maintained-apps/outputs/discord/darwin.json
  • ee/maintained-apps/outputs/github-desktop/windows.json
  • ee/maintained-apps/outputs/granola/windows.json
  • ee/maintained-apps/outputs/microsoft-outlook/darwin.json
  • ee/maintained-apps/outputs/notion/darwin.json
  • ee/maintained-apps/outputs/openvpn-connect/darwin.json
  • ee/maintained-apps/outputs/slack/darwin.json
  • ee/maintained-apps/outputs/slack/windows.json
  • ee/maintained-apps/outputs/tableau/darwin.json
  • ee/maintained-apps/outputs/thunderbird/darwin.json
  • ee/maintained-apps/outputs/thunderbird/windows.json
  • ee/maintained-apps/outputs/webex/darwin.json

Comment on lines +4 to +7
"version": "16.109",
"queries": {
"exists": "SELECT 1 FROM apps WHERE bundle_identifier = 'com.microsoft.Outlook';",
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'com.microsoft.Outlook' AND version_compare(bundle_short_version, '16.109.1') < 0);"
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'com.microsoft.Outlook' AND version_compare(bundle_short_version, '16.109') < 0);"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check git history for previous version value in this file
git log -p --follow -n 5 -- ee/maintained-apps/outputs/microsoft-outlook/darwin.json | grep -A2 -B2 '"version"'

Repository: fleetdm/fleet

Length of output: 39


🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="ee/maintained-apps/outputs/microsoft-outlook/darwin.json"

echo "== Current file (lines 1-60) =="
nl -ba "$FILE" | sed -n '1,60p'

echo
echo "== Recent commits affecting file =="
git log --follow --oneline -n 10 -- "$FILE" || true

echo
echo "== Search git history for version strings (expanded depth) =="
git log -p --follow -n 50 -- "$FILE" | rg -n --fixed-strings '"version"' || true

echo
echo "== Search git history for 16.109.1 =="
git log -p --follow -n 50 -- "$FILE" | rg -n --fixed-strings '16.109.1' || true

echo
echo "== Search repo for exact 16.109.1 in similar outputs =="
rg -n --fixed-strings '"version": "16.109.1"' ee/maintained-apps/outputs || true

echo
echo "== Search repo for 16.109.1 anywhere under maintained apps outputs =="
rg -n --fixed-strings '16.109.1' ee/maintained-apps/outputs || true

Repository: fleetdm/fleet

Length of output: 150


🏁 Script executed:

#!/bin/bash
set -u

FILE="ee/maintained-apps/outputs/microsoft-outlook/darwin.json"

echo "== Current file (lines 1-80) =="
cat -n "$FILE" | sed -n '1,80p'

echo
echo "== Recent commits affecting file =="
git log --follow --oneline -n 10 -- "$FILE" || true

echo
echo "== Search git history for version strings (expanded depth) =="
git log -p --follow -n 60 -- "$FILE" | rg -n --fixed-strings '"version"' || true

echo
echo "== Search git history for 16.109.1 =="
git log -p --follow -n 60 -- "$FILE" | rg -n --fixed-strings '16.109.1' || true

echo
echo "== Search repo for exact 16.109.1 under maintained apps outputs =="
rg -n --fixed-strings '"version": "16.109.1"' ee/maintained-apps/outputs || true

Repository: fleetdm/fleet

Length of output: 11730


🏁 Script executed:

#!/bin/bash
set -u

FILE="ee/maintained-apps/outputs/microsoft-outlook/darwin.json"
COMMIT="87e54040"

echo "== Commit files affected =="
git show --name-only --pretty="" "$COMMIT" || true

echo
echo "== Diff for Outlook file in commit $COMMIT (version-related context) =="
git show "$COMMIT":"$FILE" >/dev/null 2>&1 && echo "Commit contains $FILE"

# Show patch but filter to version_compare/version lines to keep output small
git show "$COMMIT" -- "$FILE" | rg -n --fixed-strings '"version"' || true
git show "$COMMIT" -- "$FILE" | rg -n --fixed-strings "version_compare" || true

Repository: fleetdm/fleet

Length of output: 50370


🏁 Script executed:

#!/bin/bash
set -u

FILE="ee/maintained-apps/outputs/microsoft-outlook/darwin.json"
COMMIT="87e54040"

echo "== Does git history contain 16.109.1 for this Outlook file (search by -S) =="
git log -n 5 -S '16.109.1' -- "$FILE" --oneline || true

echo
echo "== Commit $COMMIT: show only version-related lines for Outlook file =="
git show "$COMMIT" -- "$FILE" \
  | rg -n --fixed-strings '"version"' \
  || true

echo
echo "== Commit $COMMIT: show only version_compare lines for Outlook file =="
git show "$COMMIT" -- "$FILE" \
  | rg -n --fixed-strings 'version_compare' \
  || true

echo
echo "== Commit $COMMIT: show small surrounding context for version line =="
git show "$COMMIT" -- "$FILE" \
  | rg -n --context 2 --fixed-strings '"version"' \
  | head -n 40 || true

Repository: fleetdm/fleet

Length of output: 741


🏁 Script executed:

#!/bin/bash
set -u

FILE="ee/maintained-apps/outputs/microsoft-outlook/darwin.json"
COMMIT="87e54040"

echo "== In commit $COMMIT, does the Outlook diff mention 16.109.1 at all? =="
git show "$COMMIT" -- "$FILE" | rg -n --fixed-strings '16.109.1' || true

echo
echo "== In commit $COMMIT, all diff lines containing 'version' (for Outlook file) =="
git show "$COMMIT" -- "$FILE" | rg -n 'version' || true

echo
echo "== In commit $COMMIT, all diff lines containing '16.109' (for Outlook file) =="
git show "$COMMIT" -- "$FILE" | rg -n --fixed-strings '16.109' || true

Repository: fleetdm/fleet

Length of output: 8824


Remove the Outlook “version downgrade” concern; fix install/uninstall script attribution in the summary

  • ee/maintained-apps/outputs/microsoft-outlook/darwin.json sets "version": "16.109"; the updated file content/diff contains no "16.109.1" entry, so the downgrade claim isn’t reflected in the Outlook manifest.
  • install_script_ref (0e4e4b82) installs Microsoft_Outlook_16.109...Installer.pkg and relaunches the app; uninstall_script_ref (36c26399) is the one that does launchctl/receipt cleanup—so the summary attributing those cleanup actions to the install script should be corrected.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/microsoft-outlook/darwin.json` around lines 4 - 7,
The JSON incorrectly raises a “version downgrade” concern even though no
16.109.1 entry exists and the summary misattributes cleanup actions to the
installer; remove the downgrade claim related to "16.109.1" (keep "version":
"16.109" as the single source), and update the summary text to correctly state
that install_script_ref 0e4e4b82 installs
Microsoft_Outlook_16.109...Installer.pkg and relaunches the app while
uninstall_script_ref 36c26399 performs the launchctl/receipt cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants