Manage automations changes for Policies page - #45919
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
| border-collapse: collapse; | ||
|
|
||
| .data-table__wrapper { | ||
| overflow-x: auto; |
There was a problem hiding this comment.
table was not horizontally scrollable so I added this unrelated change
| ), | ||
| script: ({ name }) => ( | ||
| <Graphic | ||
| name={name.endsWith(".sh") ? "file-sh" : "file-ps1"} |
There was a problem hiding this comment.
might need to revisit this condition
| import CalendarEventsModal from "./components/CalendarEventsModal"; | ||
| import { ICalendarEventsFormData } from "./components/CalendarEventsModal/CalendarEventsModal"; | ||
| import InstallSoftwareModal from "./components/InstallSoftwareModal"; | ||
| import { IInstallSoftwareFormData } from "./components/InstallSoftwareModal/InstallSoftwareModal"; | ||
| import PolicyRunScriptModal from "./components/PolicyRunScriptModal"; | ||
| import { IPolicyRunScriptFormData } from "./components/PolicyRunScriptModal/PolicyRunScriptModal"; | ||
| import { | ||
| getInstallSoftwareErrorMessage, | ||
| getRunScriptErrorMessage, | ||
| } from "./helpers"; | ||
| import { OtherAutomationType } from "./helpers"; | ||
| import { DEFAULT_POLICY } from "../constants"; | ||
| import ConditionalAccessModal from "./components/ConditionalAccessModal"; | ||
| import { IConditionalAccessFormData } from "./components/ConditionalAccessModal/ConditionalAccessModal"; |
There was a problem hiding this comment.
In this file I removed all the imports and callbacks passed to these modals that we'll no longer use but I kept the actual files.
All the code from each of the modals will be wired up in a follow-up PR that implements the "Automations modal" (https://www.figma.com/design/QeOcex5LtuDYG9XrGnMFLZ/-42651-Easier-to-manage-policy-automations-with-continuous-retry-option-for-software-scripts?node-id=5345-6017&t=vaLDU8QQXQ7vUq1k-0) and the "Manage automations" modal (https://www.figma.com/design/QeOcex5LtuDYG9XrGnMFLZ/-42651-Easier-to-manage-policy-automations-with-continuous-retry-option-for-software-scripts?node-id=5373-9851&t=CqyECBX4tXJI5J4h-0)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## policy-automations-continuous-retries #45919 +/- ##
=========================================================================
+ Coverage 66.77% 66.88% +0.10%
=========================================================================
Files 2751 2749 -2
Lines 219881 219531 -350
Branches 10880 10755 -125
=========================================================================
Hits 146834 146834
+ Misses 59774 59424 -350
Partials 13273 13273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfd8d61
into
policy-automations-continuous-retries
2 participants
Related issue: Resolves #45145 (will do a follow-up PR for the changes in the Details page).
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Will add a single file in the feature branch (policy-automations-continuous-retries) once done with all the changes.
Testing
Screen.Recording.2026-05-20.at.3.57.29.PM.mov