Skip to content

Remove Codex CLI app and assets - #45802

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-remove-codex-cli
May 19, 2026
Merged

Remove Codex CLI app and assets#45802
allenhouchins merged 1 commit into
mainfrom
allenhouchins-remove-codex-cli

Conversation

@allenhouchins

@allenhouchins allenhouchins commented May 19, 2026

Copy link
Copy Markdown
Member

Remove Codex CLI from maintained apps: delete winget input manifest and install/uninstall scripts, remove the generated windows output (versions/refs) and the apps.json entry. Also remove frontend icon component and its image asset, and update the icons index to drop the Codex CLI mapping.

Summary by CodeRabbit

  • Chores
    • Removed Codex CLI from the platform's maintained applications, including Windows installer configurations, installation and uninstallation logic, and associated visual assets.

Review Change Stack

Remove Codex CLI from maintained apps: delete winget input manifest and install/uninstall scripts, remove the generated windows output (versions/refs) and the apps.json entry. Also remove frontend icon component and its image asset, and update the icons index to drop the Codex CLI mapping.
@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/inputs/winget/codex-cli.json

Error: File 'ee/maintained-apps/inputs/winget/codex-cli.json' does not exist

ee/maintained-apps/outputs/codex-cli/windows.json

Error: File 'ee/maintained-apps/outputs/codex-cli/windows.json' does not exist

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.76%. Comparing base (d7fa35e) to head (765330d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #45802      +/-   ##
==========================================
- Coverage   66.77%   66.76%   -0.02%     
==========================================
  Files        2748     2746       -2     
  Lines      219829   219603     -226     
  Branches    10972    10973       +1     
==========================================
- Hits       146795   146609     -186     
+ Misses      59769    59740      -29     
+ Partials    13265    13254      -11     
Flag Coverage Δ
frontend 55.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review May 19, 2026 14:54
@allenhouchins
allenhouchins requested a review from a team as a code owner May 19, 2026 14:54
Copilot AI review requested due to automatic review settings May 19, 2026 14:54
@fleet-release
fleet-release requested a review from eashaw May 19, 2026 14:54

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins
allenhouchins merged commit 4ed988f into main May 19, 2026
28 of 30 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-remove-codex-cli branch May 19, 2026 14:55
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8f310e4-71ed-4c14-8e23-2389ad85f720

📥 Commits

Reviewing files that changed from the base of the PR and between d7fa35e and 765330d.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-codex-cli-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • ee/maintained-apps/inputs/winget/codex-cli.json
  • ee/maintained-apps/inputs/winget/scripts/codex-cli_install.ps1
  • ee/maintained-apps/inputs/winget/scripts/codex-cli_uninstall.ps1
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/codex-cli/windows.json
  • frontend/pages/SoftwarePage/components/icons/CodexCli.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR removes Codex CLI from the Fleet maintained apps system and frontend. It deletes the winget input manifest (codex-cli.json), install and uninstall PowerShell scripts, the generated Windows metadata output (windows.json), the Codex CLI icon component, and all references to it in the icon registry and apps metadata list.

Possibly related PRs

  • fleetdm/fleet#42397: Adds the Codex CLI Winget manifest, installer scripts, output metadata, and frontend icon—directly inverse of these removal changes.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-remove-codex-cli

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the “Codex CLI” maintained app and related UI icon assets/mappings, reducing maintained-app surface area and keeping the Software page icon set in sync with supported apps.

Changes:

  • Removed Codex CLI from Fleet maintained-app inputs/outputs (winget input manifest + scripts, generated Windows output, and apps.json entry).
  • Removed the Codex CLI icon React component and deleted its mapping from the Software page icon registry.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/index.ts Drops the Codex CLI icon import and software-name mapping.
frontend/pages/SoftwarePage/components/icons/CodexCli.tsx Removes the Codex CLI SVG/icon component.
ee/maintained-apps/outputs/codex-cli/windows.json Removes the generated Windows manifest output for Codex CLI.
ee/maintained-apps/outputs/apps.json Removes the Codex CLI entry from the maintained apps catalog output.
ee/maintained-apps/inputs/winget/scripts/codex-cli_uninstall.ps1 Removes the Codex CLI uninstall script used by winget input.
ee/maintained-apps/inputs/winget/scripts/codex-cli_install.ps1 Removes the Codex CLI install script used by winget input.
ee/maintained-apps/inputs/winget/codex-cli.json Removes the Codex CLI winget input manifest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 461 to 465
"slug": "cloudflare-warp/windows",
"platform": "windows",
"unique_identifier": "Cloudflare WARP",
"description": "Cloudflare WARP enhances internet safety and performance by encrypting your data and optimizing connections for privacy."
},
allenhouchins added a commit that referenced this pull request May 19, 2026
Resolve modify/delete conflict for codex-cli/windows.json by accepting
main's removal of Codex CLI (#45802).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants