Remove Codex CLI app and assets - #45802
Conversation
Remove Codex CLI from maintained apps: delete winget input manifest and install/uninstall scripts, remove the generated windows output (versions/refs) and the apps.json entry. Also remove frontend icon component and its image asset, and update the icons index to drop the Codex CLI mapping.
Script Diff Resultsee/maintained-apps/inputs/winget/codex-cli.jsonError: File 'ee/maintained-apps/inputs/winget/codex-cli.json' does not existee/maintained-apps/outputs/codex-cli/windows.jsonError: File 'ee/maintained-apps/outputs/codex-cli/windows.json' does not exist |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45802 +/- ##
==========================================
- Coverage 66.77% 66.76% -0.02%
==========================================
Files 2748 2746 -2
Lines 219829 219603 -226
Branches 10972 10973 +1
==========================================
- Hits 146795 146609 -186
+ Misses 59769 59740 -29
+ Partials 13265 13254 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
WalkthroughThis PR removes Codex CLI from the Fleet maintained apps system and frontend. It deletes the winget input manifest (codex-cli.json), install and uninstall PowerShell scripts, the generated Windows metadata output (windows.json), the Codex CLI icon component, and all references to it in the icon registry and apps metadata list. Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the “Codex CLI” maintained app and related UI icon assets/mappings, reducing maintained-app surface area and keeping the Software page icon set in sync with supported apps.
Changes:
- Removed Codex CLI from Fleet maintained-app inputs/outputs (winget input manifest + scripts, generated Windows output, and
apps.jsonentry). - Removed the Codex CLI icon React component and deleted its mapping from the Software page icon registry.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/index.ts | Drops the Codex CLI icon import and software-name mapping. |
| frontend/pages/SoftwarePage/components/icons/CodexCli.tsx | Removes the Codex CLI SVG/icon component. |
| ee/maintained-apps/outputs/codex-cli/windows.json | Removes the generated Windows manifest output for Codex CLI. |
| ee/maintained-apps/outputs/apps.json | Removes the Codex CLI entry from the maintained apps catalog output. |
| ee/maintained-apps/inputs/winget/scripts/codex-cli_uninstall.ps1 | Removes the Codex CLI uninstall script used by winget input. |
| ee/maintained-apps/inputs/winget/scripts/codex-cli_install.ps1 | Removes the Codex CLI install script used by winget input. |
| ee/maintained-apps/inputs/winget/codex-cli.json | Removes the Codex CLI winget input manifest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "slug": "cloudflare-warp/windows", | ||
| "platform": "windows", | ||
| "unique_identifier": "Cloudflare WARP", | ||
| "description": "Cloudflare WARP enhances internet safety and performance by encrypting your data and optimizing connections for privacy." | ||
| }, |
Resolve modify/delete conflict for codex-cli/windows.json by accepting main's removal of Codex CLI (#45802).
Remove Codex CLI from maintained apps: delete winget input manifest and install/uninstall scripts, remove the generated windows output (versions/refs) and the apps.json entry. Also remove frontend icon component and its image asset, and update the icons index to drop the Codex CLI mapping.
Summary by CodeRabbit