Skip to content

Update Fleet-maintained apps - #45658

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2605152118
Closed

Update Fleet-maintained apps#45658
fleet-release wants to merge 1 commit into
mainfrom
fma-2605152118

Conversation

@fleet-release

@fleet-release fleet-release commented May 15, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated macOS installers for Teleport Connect and Teleport Suite to version 18.8.1

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/outputs/teleport-connect/darwin.json

=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===

ee/maintained-apps/outputs/teleport-suite/darwin.json

=== Install // 70c991f9 -> 7a279a2a ===

--- /tmp/old.69S8GM	2026-05-15 21:21:37.162557438 +0000
+++ /tmp/new.J2nZ2Y	2026-05-15 21:21:37.162557438 +0000
@@ -96,5 +96,5 @@
 
 # install pkg files
 quit_and_track_application 'com.gravitational.teleport.tsh'
-sudo installer -pkg "$TMPDIR/teleport-18.8.0.pkg" -target /
+sudo installer -pkg "$TMPDIR/teleport-18.8.1.pkg" -target /
 relaunch_application 'com.gravitational.teleport.tsh'

=== Uninstall Script (no changes) ===

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR updates the Fleet-maintained Teleport application manifests for macOS from version 18.8.0 to 18.8.1. Two files are changed: teleport-connect/darwin.json and teleport-suite/darwin.json. Each update modifies the version field, the SQL version-compare gate used for patch detection, the installer download URL, and the SHA256 checksum to match the new release. The Teleport Suite update also changes the install script reference to point to the 18.8.1 package installer.

Possibly related PRs

  • fleetdm/fleet#45334: Updates both the same Teleport manifest files with version bumps following the same pattern (18.8.0 → 18.8.1).
  • fleetdm/fleet#45565: Data-only version update to macOS maintained-apps output manifest, changing version, queries.patched threshold, installer URL, and SHA256 checksum.
  • fleetdm/fleet#45568: Structurally identical data-only version bump for a different Fleet-maintained app (Ollama) in the same ee/maintained-apps/outputs/*/darwin.json directory.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and lacks most required template sections, providing only a single sentence about automated ingestion without addressing testing, validation, or other checklist items. Complete the PR description template with appropriate checklist items, testing notes, validation confirmation, and any relevant issue references to meet repository requirements.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is vague and generic, using broad terminology that doesn't specify which apps were updated or what the actual changes are. Provide a more specific title that indicates the nature of the update, such as 'Update Teleport Connect and Teleport Suite to version 18.8.1' or similar details.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605152118

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/teleport-connect/darwin.json`:
- Line 9: The darwin.json entry currently points installer_url
"https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg" to a non-existent
Teleport Connect 18.8.1; update this entry by replacing the installer_url and
corresponding sha256 with the correct 18.8.0 values (or remove the entire 18.8.1
object if you prefer not to include it). Locate the JSON object containing the
"installer_url" key and the associated "sha256" for Teleport Connect 18.8.1 and
either change both fields to the official 18.8.0 URL and checksum or delete that
object so only valid releases remain.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e4e0f09c-8fb7-4c8a-a91a-eec192eca85e

📥 Commits

Reviewing files that changed from the base of the PR and between 9c6039e and 7b85de7.

📒 Files selected for processing (2)
  • ee/maintained-apps/outputs/teleport-connect/darwin.json
  • ee/maintained-apps/outputs/teleport-suite/darwin.json

"patched": "SELECT 1 WHERE NOT EXISTS ((SELECT 1 FROM apps WHERE bundle_identifier = 'gravitational.teleport.connect') AND version_compare(bundle_short_version, '18.8.1') < 0);"
},
"installer_url": "https://cdn.teleport.dev/Teleport%20Connect-18.8.0.dmg",
"installer_url": "https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Download and verify SHA256 checksum for Teleport Connect 18.8.1 DMG

EXPECTED_SHA256="a04626b6902ed41b2200e39a87244474215ef65d6c5ce6c8a3b07f6cec6aee66"
INSTALLER_URL="https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg"

echo "Downloading installer to compute SHA256..."
ACTUAL_SHA256=$(curl -sL "$INSTALLER_URL" | shasum -a 256 | awk '{print $1}')

echo "Expected: $EXPECTED_SHA256"
echo "Actual:   $ACTUAL_SHA256"

if [ "$EXPECTED_SHA256" = "$ACTUAL_SHA256" ]; then
  echo "✓ Checksum matches"
  exit 0
else
  echo "✗ Checksum mismatch"
  exit 1
fi

Repository: fleetdm/fleet

Length of output: 269


🏁 Script executed:

#!/bin/bash
# Alternative verification using Python's hashlib
EXPECTED_SHA256="a04626b6902ed41b2200e39a87244474215ef65d6c5ce6c8a3b07f6cec6aee66"
INSTALLER_URL="https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg"

echo "Attempting to download and verify checksum using Python..."
python3 << 'EOF'
import hashlib
import urllib.request
import sys

expected = "a04626b6902ed41b2200e39a87244474215ef65d6c5ce6c8a3b07f6cec6aee66"
url = "https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg"

try:
    print("Downloading installer...")
    response = urllib.request.urlopen(url, timeout=30)
    sha256_hash = hashlib.sha256()
    
    # Read in chunks to handle large files
    chunk_size = 8192
    while True:
        chunk = response.read(chunk_size)
        if not chunk:
            break
        sha256_hash.update(chunk)
    
    actual = sha256_hash.hexdigest()
    print(f"Expected: {expected}")
    print(f"Actual:   {actual}")
    
    if expected == actual:
        print("✓ Checksum matches")
        sys.exit(0)
    else:
        print("✗ Checksum mismatch")
        sys.exit(1)
except Exception as e:
    print(f"Error: {e}")
    sys.exit(2)
EOF

Repository: fleetdm/fleet

Length of output: 276


🌐 Web query:

Teleport Connect 18.8.1 DMG sha256 checksum release

💡 Result:

As of May 15, 2026, there is no release of Teleport Connect version 18.8.1. The most recent major release in the 18.8.x series is 18.8.0, which was released on May 7, 2026 [1]. Teleport does not publish a static list of SHA256 checksums for all versions in a single document. Instead, checksums are provided dynamically for each specific download file [2]. To obtain the SHA256 checksum for a Teleport Connect DMG file, you can append.sha256 to the download URL of the installer [2]. For official downloads and to verify the integrity of any Teleport release, you should always use the official Teleport downloads page at https://goteleport.com/download [3][4].

Citations:


Remove or update the non-existent version 18.8.1. Teleport Connect version 18.8.1 does not exist; the latest release in the 18.8.x series is 18.8.0 (released May 7, 2026). The installer URL and SHA256 checksum reference a file that should not be used. Update the entry to use the correct version or remove it entirely.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/teleport-connect/darwin.json` at line 9, The
darwin.json entry currently points installer_url
"https://cdn.teleport.dev/Teleport%20Connect-18.8.1.dmg" to a non-existent
Teleport Connect 18.8.1; update this entry by replacing the installer_url and
corresponding sha256 with the correct 18.8.0 values (or remove the entire 18.8.1
object if you prefer not to include it). Locate the JSON object containing the
"installer_url" key and the associated "sha256" for Teleport Connect 18.8.1 and
either change both fields to the official 18.8.0 URL and checksum or delete that
object so only valid releases remain.

@github-actions

Copy link
Copy Markdown
Contributor

Closing in favor of #45666.

@github-actions github-actions Bot closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants