Skip to content

Update Fleet-maintained apps - #45646

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2605152024
Closed

Update Fleet-maintained apps#45646
fleet-release wants to merge 1 commit into
mainfrom
fma-2605152024

Conversation

@fleet-release

@fleet-release fleet-release commented May 15, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated version metadata and installation packages for multiple applications: Codex CLI, Cursor, Figma, GoLand, IntelliJ IDEA, Microsoft Edge, RubyMine, Tailscale, and Zed. All updates reflect the latest available application releases with refreshed checksums and download links.

Review Change Stack

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR bumps version metadata and installer artifacts for 9 maintained applications: Codex CLI (0.116.0 → 0.130.0), Cursor macOS/Windows (3.4.17/3.4.16 → 3.4.20), Figma Windows (126.3.12 → 126.4.9), GoLand macOS (2026.1.1 → 2026.1.2), IntelliJ IDEA macOS (→ 2026.1.2), Microsoft Edge macOS (148.0.3967.54 → 148.0.3967.70), RubyMine macOS (2026.1.1 → 2026.1.2), Tailscale Windows (1.98.1 → 1.98.2), and Zed macOS (1.2.5 → 1.2.6). Each update replaces the version string, SQL version-comparison predicate, installer URL, and SHA256 checksum.

Possibly related PRs

  • fleetdm/fleet#44655: Updates Cursor macOS and Windows maintained-app metadata (version, queries.patched, installer_url, sha256) to align with new releases.
  • fleetdm/fleet#44977: Updates Microsoft Edge macOS maintained-app manifest with new version, version-compare gate, installer URL, and checksum.
  • fleetdm/fleet#45334: Updates Zed macOS entry in maintained-apps with version bump, patched-version threshold, installer URL, and SHA256.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and generic; it lacks specific details about which apps were updated, version changes, and affected platforms, making it difficult to understand the scope of changes. Expand the description to specify which applications were updated, their version changes, and affected platforms. Consider providing a summary list of changes or referencing the related issue.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title "Update Fleet-maintained apps" clearly summarizes the main change: updating configuration data for multiple maintained applications across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2605152024

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/codex-cli/windows.json`:
- Line 7: The SQL in the "patched" value applies version_compare only to the
AppData branch because AND binds tighter than OR; update the query string (the
"patched" entry) so the two path checks are grouped with parentheses — e.g.,
wrap "path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE
'%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe'" in parentheses so the AND
version_compare(...) < 0 applies to both paths.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bab9404d-64f6-48c8-b519-e8559aec9cba

📥 Commits

Reviewing files that changed from the base of the PR and between 1e22a58 and 999ea49.

📒 Files selected for processing (10)
  • ee/maintained-apps/outputs/codex-cli/windows.json
  • ee/maintained-apps/outputs/cursor/darwin.json
  • ee/maintained-apps/outputs/cursor/windows.json
  • ee/maintained-apps/outputs/figma/windows.json
  • ee/maintained-apps/outputs/goland/darwin.json
  • ee/maintained-apps/outputs/intellij-idea/darwin.json
  • ee/maintained-apps/outputs/microsoft-edge/darwin.json
  • ee/maintained-apps/outputs/rubymine/darwin.json
  • ee/maintained-apps/outputs/tailscale/windows.json
  • ee/maintained-apps/outputs/zed/darwin.json

"queries": {
"exists": "SELECT 1 FROM file WHERE path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe';",
"patch": ""
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM file WHERE path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe' AND version_compare(version, '0.130.0') < 0);"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python - <<'PY'
import json, re
from pathlib import Path

p = Path("ee/maintained-apps/outputs/codex-cli/windows.json")
q = json.loads(p.read_text())["versions"][0]["queries"]["patched"]

print("patched query:")
print(q)

pattern = r"path = .* OR .*path LIKE .* AND version_compare"
print("\nprecedence-risk-pattern:", bool(re.search(pattern, q)))
PY

Repository: fleetdm/fleet

Length of output: 307


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Check for similar patterns in the same file and related files
echo "=== Checking for similar OR...AND patterns in the codex-cli file ==="
python - <<'PY'
import json, re
from pathlib import Path

p = Path("ee/maintained-apps/outputs/codex-cli/windows.json")
content = json.loads(p.read_text())

# Check all queries for OR...AND patterns
for idx, version_entry in enumerate(content.get("versions", [])):
    queries = version_entry.get("queries", {})
    for query_name, query_str in queries.items():
        if re.search(r"OR\s+.*AND\s+", query_str, re.IGNORECASE):
            print(f"\nVersion {idx}, Query '{query_name}':")
            print(f"  {query_str[:200]}...")
PY

echo ""
echo "=== Check if there are similar files that might have the same issue ==="
find ee/maintained-apps/outputs -name "*.json" -type f | head -5

Repository: fleetdm/fleet

Length of output: 682


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Examining the structure and context of codex-cli windows.json ==="
python - <<'PY'
import json
from pathlib import Path

p = Path("ee/maintained-apps/outputs/codex-cli/windows.json")
data = json.loads(p.read_text())

# Show overall structure
print("Top-level keys:", list(data.keys()))
print("\nNumber of versions:", len(data.get("versions", [])))

# Show version 0 details
if data.get("versions"):
    v0 = data["versions"][0]
    print("\nVersion 0 keys:", list(v0.keys()))
    print("Version 0 'version' field:", v0.get("version"))
    print("Version 0 'released_at':", v0.get("released_at"))
    print("\nAll query names:", list(v0.get("queries", {}).keys()))
    
    # Show the patched query in detail
    patched_q = v0["queries"]["patched"]
    print("\nPatched query full:")
    print(patched_q)
    
    # Try to find uninstall query for comparison
    if "uninstall" in v0["queries"]:
        print("\nUninstall query for comparison:")
        print(v0["queries"]["uninstall"][:200])
PY

echo ""
echo "=== Check if other applications have similar install path patterns ==="
# Look at another file to see if there's a pattern
cat ee/maintained-apps/outputs/7-zip/windows.json | python -m json.tool | head -80

Repository: fleetdm/fleet

Length of output: 2900


Fix operator precedence in the patched query.

On line 7, AND has higher precedence than OR, so version_compare is only applied to the AppData path branch. This causes Program Files installs to always be reported as unpatched, regardless of version. Wrap the path conditions in parentheses to ensure the version check applies to both installation paths:

Proposed fix
-        "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM file WHERE path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe' AND version_compare(version, '0.130.0') < 0);"
+        "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM file WHERE (path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe') AND version_compare(version, '0.130.0') < 0);"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM file WHERE path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe' AND version_compare(version, '0.130.0') < 0);"
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM file WHERE (path = 'C:\\Program Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex CLI\\codex.exe') AND version_compare(version, '0.130.0') < 0);"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/codex-cli/windows.json` at line 7, The SQL in the
"patched" value applies version_compare only to the AppData branch because AND
binds tighter than OR; update the query string (the "patched" entry) so the two
path checks are grouped with parentheses — e.g., wrap "path = 'C:\\Program
Files\\Codex CLI\\codex.exe' OR path LIKE '%\\AppData\\Local\\Programs\\Codex
CLI\\codex.exe'" in parentheses so the AND version_compare(...) < 0 applies to
both paths.

@github-actions

Copy link
Copy Markdown
Contributor

Closing in favor of #45652.

@github-actions github-actions Bot closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants