Fix for ONC profiles losing their details when adding another profile (#45299) - #45311
Merged
Merged
Conversation
…#45299) <!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #42405 Unreleased bug fix. # Checklist for submitter ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Android MDM profile detail messages (e.g., certificate status) are preserved when adding additional profiles or marking profiles pending, preventing loss of important status information. * **Tests** * Added an integration test verifying ONC/certificate detail is retained when additional Android MDM profiles are uploaded for the same team. [](https://app.coderabbit.ai/change-stack/fleetdm/fleet/pull/45299) <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit 7e3dea6)
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
ksykulev
approved these changes
May 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.85.0 #45311 +/- ##
==========================================================
+ Coverage 66.72% 68.61% +1.88%
==========================================================
Files 2626 1584 -1042
Lines 211198 183160 -28038
Branches 9428 0 -9428
==========================================================
- Hits 140924 125676 -15248
+ Misses 57485 44751 -12734
+ Partials 12789 12733 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #42405
Unreleased bug fix.
Checklist for submitter
Testing
Summary by CodeRabbit
Bug Fixes
Android MDM profile detail messages (e.g., certificate status) are preserved when adding additional profiles or marking profiles pending, preventing loss of important status information.
Tests
Added an integration test verifying ONC/certificate detail is retained when additional Android MDM profiles are uploaded for the same team.
(cherry picked from commit 7e3dea6)