Update Fleet-maintained apps - #45209
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Script Diff Resultsee/maintained-apps/outputs/chatgpt-atlas/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/cloudflare-warp/darwin.json=== Install // 49891dfb -> e97d4551 ===
--- /tmp/old.dJS3XH 2026-05-12 03:21:47.031494316 +0000
+++ /tmp/new.KiAXC5 2026-05-12 03:21:47.031494316 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.cloudflare.1dot1dot1dot1.macos'
-sudo installer -pkg "$TMPDIR/Cloudflare_WARP_2026.3.846.0.pkg" -target /
+sudo installer -pkg "$TMPDIR/Cloudflare_WARP_2026.4.1350.0.pkg" -target /
relaunch_application 'com.cloudflare.1dot1dot1dot1.macos'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/discord/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/openvpn-connect/darwin.json=== Install // c8881523 -> 2ebecc60 ===
--- /tmp/old.z2p9fq 2026-05-12 03:21:47.124496370 +0000
+++ /tmp/new.KixCzy 2026-05-12 03:21:47.124496370 +0000
@@ -1,29 +1,6 @@
#!/bin/bash
# Custom install script for OpenVPN Connect on macOS.
-#
-# The Homebrew cask "openvpn-connect" downloads a .dmg that contains both
-# x86_64 and arm64 .pkg installers at the root of the mounted volume:
-#
-# OpenVPN_Connect_<ver>(<build>)_x86_64_Installer_signed.pkg
-# OpenVPN_Connect_<ver>(<build>)_arm64_Installer_signed.pkg
-#
-# We only ship FMAs for Apple Silicon (arm64) on macOS, so this script:
-# 1. Mounts the DMG.
-# 2. Locates the arm64 .pkg via a glob (parentheses in the file name make
-# hard-coding the path brittle across versions).
-# 3. Quits the app if it's running and tracks state for relaunch.
-# 4. Runs `installer -pkg ... -target /` against the mounted pkg, which is
-# the same operation Homebrew performs for `pkg "..."` artifacts.
-# 5. Detaches the DMG.
-# 6. Forces LaunchServices to register the installed .app bundle.
-#
-# The LaunchServices step is required because OpenVPN Connect 3.8+ installs
-# into a wrapper directory (/Applications/OpenVPN Connect/OpenVPN Connect.app)
-# rather than placing the .app directly under /Applications/. osquery's `apps`
-# table only directory-scans the top level of /Applications/ and otherwise
-# relies on LaunchServices to discover nested apps; without an explicit
-# `lsregister` the freshly installed app may not show up immediately.
set -u
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/pgadmin4/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
WalkthroughThis PR updates metadata manifests for five managed applications across macOS and Windows platforms. ChatGPT Atlas, Cloudflare WARP, Discord, and pgAdmin4 each receive version bumps paired with updated installer URLs and SHA256 checksums. Cloudflare WARP also points to a new installation script with updated package filename. OpenVPN Connect switches its installation script reference while preserving the overall installation control flow. All updates maintain existing unmodified references where applicable. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ee/maintained-apps/outputs/cloudflare-warp/darwin.json (1)
20-20: ⚡ Quick winConsider using
$INSTALLER_PATHdirectly instead of hardcoding the package filename.The install script hardcodes
Cloudflare_WARP_2026.4.1350.0.pkgrather than using$INSTALLER_PATHdirectly or deriving the filename dynamically. This creates a fragile dependency where the installation will fail if the downloaded file is named differently.♻️ Suggested refactor
Replace the hardcoded package path with
$INSTALLER_PATH:-sudo installer -pkg "$TMPDIR/Cloudflare_WARP_2026.4.1350.0.pkg" -target / +sudo installer -pkg "$INSTALLER_PATH" -target /This eliminates the need to update the script for every version change and makes the installation more resilient to naming variations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/cloudflare-warp/darwin.json` at line 20, The installer invocation hardcodes "Cloudflare_WARP_2026.4.1350.0.pkg" which breaks when filenames change; update the sudo installer line to use the provided $INSTALLER_PATH (properly quoted) instead of the hardcoded filename, leaving quit_and_track_application and relaunch_application calls intact and ensuring TMPDIR can remain if still needed elsewhere.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ee/maintained-apps/outputs/cloudflare-warp/darwin.json`:
- Line 20: The installer invocation hardcodes
"Cloudflare_WARP_2026.4.1350.0.pkg" which breaks when filenames change; update
the sudo installer line to use the provided $INSTALLER_PATH (properly quoted)
instead of the hardcoded filename, leaving quit_and_track_application and
relaunch_application calls intact and ensuring TMPDIR can remain if still needed
elsewhere.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f3b675d4-731f-4159-ac1f-471facc49a96
📒 Files selected for processing (5)
ee/maintained-apps/outputs/chatgpt-atlas/darwin.jsonee/maintained-apps/outputs/cloudflare-warp/darwin.jsonee/maintained-apps/outputs/discord/windows.jsonee/maintained-apps/outputs/openvpn-connect/darwin.jsonee/maintained-apps/outputs/pgadmin4/darwin.json
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit