Switch scripts to bash and update refs - #44853
Merged
Merged
Conversation
Replace /bin/sh shebangs with /bin/bash across numerous Homebrew input scripts to support bash-specific constructs (local, arrays, [[ ]], etc.). Update darwin.json refs for multiple apps (notably 1password, adobe-acrobat-pro, adobe-creative-cloud) to point to new install/uninstall script refs and replace inline script bodies with bash variants. Also remove ee/maintained-apps/outputs/docker/darwin.json. Changes affect ee/maintained-apps/inputs/homebrew/scripts/* and corresponding ee/maintained-apps/outputs/* darwin.json entries.
fleet-release
approved these changes
May 6, 2026
Contributor
Script Diff Resultsee/maintained-apps/outputs/1password/darwin.json=== Install // 90335256 -> ef2a17ff ===
--- /tmp/old.Gr4rMV 2026-05-06 16:57:11.870178917 +0000
+++ /tmp/new.9wNZFq 2026-05-06 16:57:11.870178917 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/adobe-acrobat-pro/darwin.json=== Install // cc10a586 -> a5a610c0 ===
--- /tmp/old.Z0J2BD 2026-05-06 16:57:11.984180396 +0000
+++ /tmp/new.P7xwtx 2026-05-06 16:57:11.984180396 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // c098bf7c -> 92dda6e7 ===
--- /tmp/old.G8Yvtk 2026-05-06 16:57:11.998180555 +0000
+++ /tmp/new.0fUgTb 2026-05-06 16:57:11.998180555 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
LOGGED_IN_USER=$(scutil <<< "show State:/Users/ConsoleUser" | awk '/Name :/ { print $3 }')ee/maintained-apps/outputs/adobe-creative-cloud/darwin.json=== Install // 1ad8f626 -> a331ea84 ===
--- /tmp/old.2NThjK 2026-05-06 16:57:12.046181100 +0000
+++ /tmp/new.ha50MC 2026-05-06 16:57:12.047181112 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
bundle_id="$1"
=== Uninstall // 0f729ae8 -> e002ddef ===
--- /tmp/old.ptUDwo 2026-05-06 16:57:12.062181282 +0000
+++ /tmp/new.nYEfBQ 2026-05-06 16:57:12.062181282 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_app() {
b="$1"ee/maintained-apps/outputs/backblaze/darwin.json=== Install // 33648251 -> 17ec084a ===
--- /tmp/old.3617Rx 2026-05-06 16:57:12.133182089 +0000
+++ /tmp/new.Euij5k 2026-05-06 16:57:12.133182089 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
bundle_id="$1"
=== Uninstall // 7417e7ec -> 019c993c ===
--- /tmp/old.r5GJ13 2026-05-06 16:57:12.146182237 +0000
+++ /tmp/new.GkL7OB 2026-05-06 16:57:12.146182237 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_app() {
b="$1"ee/maintained-apps/outputs/cleanmymac/darwin.json=== Install Script (no changes) ===
=== Uninstall // 76fe1507 -> 6b7419ac ===
--- /tmp/old.ssZPDW 2026-05-06 16:57:12.186182691 +0000
+++ /tmp/new.lY0DTP 2026-05-06 16:57:12.186182691 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/dbeaver-enterprise/darwin.json=== Install // f2902602 -> a96abe07 ===
--- /tmp/old.8i2yCx 2026-05-06 16:57:12.231183202 +0000
+++ /tmp/new.3DpUaK 2026-05-06 16:57:12.232183214 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dbeaverlite/darwin.json=== Install // 8204606b -> c1cba05a ===
--- /tmp/old.a6TPHE 2026-05-06 16:57:12.287183839 +0000
+++ /tmp/new.rLYf6t 2026-05-06 16:57:12.287183839 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dbeaverultimate/darwin.json=== Install // 604c7581 -> 0a44a77f ===
--- /tmp/old.0N3Poo 2026-05-06 16:57:12.324184259 +0000
+++ /tmp/new.zKU5eJ 2026-05-06 16:57:12.324184259 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/docker/darwin.jsonError: File 'ee/maintained-apps/outputs/docker/darwin.json' does not existee/maintained-apps/outputs/evernote/darwin.json=== Install // c4c66da7 -> a83831d7 ===
--- /tmp/old.ZvlgNp 2026-05-06 16:57:12.416185305 +0000
+++ /tmp/new.kAkiKc 2026-05-06 16:57:12.416185305 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // 7be36873 -> 31b95715 ===
--- /tmp/old.9HS7eR 2026-05-06 16:57:12.429185452 +0000
+++ /tmp/new.UsxDY8 2026-05-06 16:57:12.429185452 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/expressvpn/darwin.json=== Install // ebbdc77b -> c5afbbfa ===
--- /tmp/old.vy19QK 2026-05-06 16:57:12.465185862 +0000
+++ /tmp/new.djQX71 2026-05-06 16:57:12.465185862 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/filemaker-pro/darwin.json=== Install // 72d274ec -> 387db5f0 ===
--- /tmp/old.vhqhxB 2026-05-06 16:57:12.520186486 +0000
+++ /tmp/new.kIh56S 2026-05-06 16:57:12.520186486 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // f4f1edf6 -> ab29479d ===
--- /tmp/old.xBllH7 2026-05-06 16:57:12.533186634 +0000
+++ /tmp/new.8uhWuI 2026-05-06 16:57:12.533186634 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/github/darwin.json=== Install // 37511289 -> 98ab6ed8 ===
--- /tmp/old.2p4Fsb 2026-05-06 16:57:12.571187066 +0000
+++ /tmp/new.B87iVA 2026-05-06 16:57:12.571187066 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/google-chrome/darwin.json=== Install // 0eca52a6 -> 6981ff84 ===
--- /tmp/old.2UjcqT 2026-05-06 16:57:12.608187486 +0000
+++ /tmp/new.3dfjUq 2026-05-06 16:57:12.608187486 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/google-gemini/darwin.json=== Install // 6e7ec188 -> 5a341444 ===
--- /tmp/old.V9w8lU 2026-05-06 16:57:12.654188009 +0000
+++ /tmp/new.uC6zbI 2026-05-06 16:57:12.654188009 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // e78a7042 -> f057dea3 ===
--- /tmp/old.BFq5U0 2026-05-06 16:57:12.669188179 +0000
+++ /tmp/new.EULZTg 2026-05-06 16:57:12.669188179 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/gpg-suite/darwin.json=== Install Script (no changes) ===
=== Uninstall // 0a25b397 -> e3b19a58 ===
--- /tmp/old.UTtg1R 2026-05-06 16:57:12.709188634 +0000
+++ /tmp/new.z5KB7n 2026-05-06 16:57:12.710188645 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
LOGGED_IN_USER=$(scutil <<< "show State:/Users/ConsoleUser" | awk '/Name :/ { print $3 }')ee/maintained-apps/outputs/grammarly-desktop/darwin.json=== Install // 2787b849 -> 20d5bd8f ===
--- /tmp/old.onI3OE 2026-05-06 16:57:12.746189055 +0000
+++ /tmp/new.1jXk7g 2026-05-06 16:57:12.746189055 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/keeper-password-manager/darwin.json=== Install // b8bbdf14 -> 451e3989 ===
--- /tmp/old.ysmYva 2026-05-06 16:57:12.849190225 +0000
+++ /tmp/new.oyqTPm 2026-05-06 16:57:12.849190225 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // 12611891 -> 21a57d3e ===
--- /tmp/old.AQpiZP 2026-05-06 16:57:12.861190361 +0000
+++ /tmp/new.WbUVFh 2026-05-06 16:57:12.862190373 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/logi-options+/darwin.json=== Install // 7a2d7dc9 -> 9c6085d5 ===
--- /tmp/old.zkHdZ6 2026-05-06 16:57:12.919191020 +0000
+++ /tmp/new.9i9hDn 2026-05-06 16:57:12.919191020 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // 422435f6 -> 0a51dedb ===
--- /tmp/old.Ip00Gs 2026-05-06 16:57:12.933191179 +0000
+++ /tmp/new.gskKjm 2026-05-06 16:57:12.933191179 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
LOGGED_IN_USER=$(scutil <<< "show State:/Users/ConsoleUser" | awk '/Name :/ { print $3 }')ee/maintained-apps/outputs/microsoft-edge/darwin.json=== Install // a4fedc24 -> caf6f785 ===
--- /tmp/old.8nLazU 2026-05-06 16:57:12.969191588 +0000
+++ /tmp/new.EDvZCe 2026-05-06 16:57:12.970191600 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-word/darwin.json=== Install Script (no changes) ===
=== Uninstall // 7cc2de6f -> 6d6819ed ===
--- /tmp/old.0rZIG7 2026-05-06 16:57:13.020192168 +0000
+++ /tmp/new.XGOxHB 2026-05-06 16:57:13.020192168 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
LOGGED_IN_USER=$(scutil <<< "show State:/Users/ConsoleUser" | awk '/Name :/ { print $3 }')ee/maintained-apps/outputs/omnigraffle/darwin.json=== Install // ef22700e -> d2d63787 ===
--- /tmp/old.SlC67h 2026-05-06 16:57:13.055192566 +0000
+++ /tmp/new.H4IA39 2026-05-06 16:57:13.055192566 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/p4v/darwin.json=== Install // 804d7fe0 -> bbe80cf5 ===
--- /tmp/old.ErcvOr 2026-05-06 16:57:13.095193020 +0000
+++ /tmp/new.qEDjci 2026-05-06 16:57:13.095193020 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"
=== Uninstall // 6f04fef2 -> 428bb3f6 ===
--- /tmp/old.BGfqXz 2026-05-06 16:57:13.144193577 +0000
+++ /tmp/new.CuBBQg 2026-05-06 16:57:13.144193577 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"ee/maintained-apps/outputs/quip/darwin.json=== Install // f98672c5 -> c9758472 ===
--- /tmp/old.jxp6Vm 2026-05-06 16:57:13.227194520 +0000
+++ /tmp/new.qdKxTd 2026-05-06 16:57:13.227194520 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // dd5d6524 -> 0c770e6a ===
--- /tmp/old.48m7Os 2026-05-06 16:57:13.240194668 +0000
+++ /tmp/new.VRTnIp 2026-05-06 16:57:13.240194668 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/royal-tsx/darwin.json=== Install // dde89f92 -> 8a40c4cb ===
--- /tmp/old.jY6uS9 2026-05-06 16:57:13.275195065 +0000
+++ /tmp/new.nBOC7V 2026-05-06 16:57:13.275195065 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/slack/darwin.json=== Install // 17356f4e -> 6025885d ===
--- /tmp/old.o9V7GG 2026-05-06 16:57:13.311195475 +0000
+++ /tmp/new.fMmbCV 2026-05-06 16:57:13.311195475 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/telegram/darwin.json=== Install // 60ca098a -> 16c0d6bd ===
--- /tmp/old.9D7aXH 2026-05-06 16:57:13.398196463 +0000
+++ /tmp/new.5ycJcY 2026-05-06 16:57:13.398196463 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"
=== Uninstall // a39fa3ea -> ab69ee4f ===
--- /tmp/old.JfVm2A 2026-05-06 16:57:13.411196611 +0000
+++ /tmp/new.WLZWn7 2026-05-06 16:57:13.411196611 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
APPDIR="/Applications/"ee/maintained-apps/outputs/teleport-suite/darwin.json=== Install Script (no changes) ===
=== Uninstall // 42474e69 -> 343cb8f4 ===
--- /tmp/old.vVblY5 2026-05-06 16:57:13.448197031 +0000
+++ /tmp/new.C3Rqjg 2026-05-06 16:57:13.448197031 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# variables
LOGGED_IN_USER=$(scutil <<< "show State:/Users/ConsoleUser" | awk '/Name :/ { print $3 }')ee/maintained-apps/outputs/zoom/darwin.json=== Install // e1921ced -> 05e6a85c ===
--- /tmp/old.70uYuf 2026-05-06 16:57:13.485197452 +0000
+++ /tmp/new.GKYwWt 2026-05-06 16:57:13.485197452 +0000
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
quit_application() {
local bundle_id="$1"
=== Uninstall Script (no changes) === |
allenhouchins
marked this pull request as ready for review
May 6, 2026 17:21
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
fleet-release
approved these changes
May 6, 2026
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (54)
WalkthroughThis pull request updates 24 installer/uninstaller shell scripts in the homebrew inputs directory by changing the shebang from Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace /bin/sh shebangs with /bin/bash across numerous Homebrew input scripts to support bash-specific constructs (local, arrays, [[ ]], etc.). Update darwin.json refs for multiple apps (notably 1password, adobe-acrobat-pro, adobe-creative-cloud) to point to new install/uninstall script refs and replace inline script bodies with bash variants. Also remove ee/maintained-apps/outputs/docker/darwin.json. Changes affect ee/maintained-apps/inputs/homebrew/scripts/* and corresponding ee/maintained-apps/outputs/* darwin.json entries.
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores