Cherry-pick #44771: Dark mode tweaks: error pages text contrast, dropdown borders, table corners - #44844
Merged
Merged
Conversation
…corners (#44771) **Related issue:** N/A — ad-hoc dark-mode polish (revives fixes from the closed #43675) ## Summary - **Error pages (403/404/500)**: replaced hardcoded `#333` body text with `$core-fleet-black` so the copy adapts to dark mode. - **Dropdown menu border**: added border to `ActionsDropdown` ONLY in dark mode (light mode already has a box-shadow which in dark mode is basically not visible so it's hard to distinguish what's in front and what's behind when opening a dropdown). - **Table bottom-right corner**: tables such as UsersTable have the Actions dropdown in the last cell, and I think this made the bottom-right corner to be cut because of a missing border-radius on the inner cell that matches the table's border radius. # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] QA'd all new/changed functionality manually | # | Before | After | |---|--------|-------| | Not found page | <img height="700" alt="Screenshot 2026-05-06 at 3 43 44 PM" src="https://github.com/user-attachments/assets/c52b7bf8-6c5e-4e2e-8635-6f660c59ee90" /> | <img height="700" alt="Screenshot 2026-05-06 at 3 35 03 PM" src="https://github.com/user-attachments/assets/e92c324f-92a9-4e5e-a048-ab2b1d3c87a3" /> | | Access denied page | <img height="700" alt="Screenshot 2026-05-06 at 3 43 58 PM" src="https://github.com/user-attachments/assets/9093f51a-e8ce-495b-9820-37ab5a7ff4cf" /> | <img height="700" alt="Screenshot 2026-05-06 at 3 34 54 PM" src="https://github.com/user-attachments/assets/3b9fe930-0ba1-4d48-824b-1b2cda713211" /> | | ActionsDropdown border + Table bottom corners (*) | <img height="700" alt="Screenshot 2026-05-06 at 3 46 35 PM" src="https://github.com/user-attachments/assets/c16b5a52-4746-4603-9f26-92be82f24225" /> | <img height="700" alt="Screenshot 2026-05-06 at 3 31 33 PM" src="https://github.com/user-attachments/assets/0a77cc95-40c4-43d2-9c6b-24c81782b275" /> | (*) Note that in the Users table, which has the Actions dropdown, the right bottom corner is cut because the inner element doesn't respect the table's border radius. Fixed this by adding the same border-radius to that cell. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed a display issue where data table bottom-right corners were being cut off, ensuring complete visibility of table content. * Improved dark mode contrast and readability on error pages (403, 404, and 500 errors). * **New Features** * Added visual borders to dropdown menus for improved clarity and user interaction feedback. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
cdcme
approved these changes
May 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.85.0 #44844 +/- ##
==========================================================
+ Coverage 66.72% 66.74% +0.01%
==========================================================
Files 2626 2626
Lines 211198 211104 -94
Branches 9428 9552 +124
==========================================================
- Hits 140924 140897 -27
+ Misses 57485 57419 -66
+ Partials 12789 12788 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #44771 into the RC branch.