Fleet UI: Controls > Setup experience descriptions cleanup - #44824
Conversation
| // that render content via React Router children instead of <TabPanel>. | ||
| // Pages that key this element by pathname get the fade on every route change. | ||
| // ManageControlsPage omits the key here and uses __fade (keyed by tab index) | ||
| // so only top-level tab switches animate, not sub-route navigation. |
| <div className="tab-nav-routed-content"> | ||
| <div | ||
| key={getTabIndex(pathname)} | ||
| className="tab-nav-routed-content__fade" |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #44824 +/- ##
========================================
Coverage 66.68% 66.68%
========================================
Files 2664 2671 +7
Lines 214604 214804 +200
Branches 9878 9823 -55
========================================
+ Hits 143114 143252 +138
- Misses 58469 58529 +60
- Partials 13021 13023 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR refactors the "Setup experience" pages to surface section descriptions on empty states. It adds Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue
Closes #37827
Description
Screen recording
Watch recording 2x
https://fleetdm.zoom.us/clips/share/Vvv0mCm5TkKsEKzUR3YizQ
Testing
Summary by CodeRabbit
Release Notes
New Features
Style
Tests