LabelForm: replace 'teams' with 'fleets' - #44770
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis pull request renames terminology in the label form from "teams" to "fleets" to align with Fleet's actual product naming. The immutableFields prop in DynamicLabelForm and ManualLabelForm now includes "fleets" instead of "teams" when a team/fleet is present. TeamNameField updates its FormField label and name attributes to use "Fleet" and "fleet_name" respectively. Test cases for LabelForm verify the updated help text copy reflects the new immutable field terminology. A changelog entry documents the change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
frontend/pages/labels/components/LabelForm/LabelForm.tests.tsx (1)
106-125: 💤 Low valueRemove the vacuous
immutableFields.lengthassertion.Line 124 asserts the length of a locally declared constant (
const immutableFields = ["reports", "platforms"]), which always passes and tests the test fixture rather than the component under test. It provides no signal aboutLabelForm's behaviour.🧹 Proposed cleanup
expect( screen.getByText( "Label reports and platforms are immutable. To make changes, delete this label and create a new one." ) ).toBeInTheDocument(); - - expect(immutableFields.length).toBe(2); });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/pages/labels/components/LabelForm/LabelForm.tests.tsx` around lines 106 - 125, The test "should render correct immutable help text for two fields (DynamicLabelForm without fleet)" declares immutableFields and then asserts immutableFields.length, which is vacuous; remove the line expect(immutableFields.length).toBe(2) from LabelForm.tests.tsx so the test only asserts the rendered output from the LabelForm component (keep the render call and the screen.getByText assertion that checks the immutable help text).frontend/pages/labels/components/TeamNameField/TeamNameField.tsx (1)
9-15: 💤 Low valueConsider renaming
TeamNameFieldtoFleetNameFieldfor consistency.The component file name and export
TeamNameFieldrender a "Fleet" label, creating a semantic mismatch. Since this is a display-only component, there's no runtime impact, but the naming inconsistency will confuse maintainers. The rename is straightforward—only one file imports this component (LabelForm.tsx), making it genuinely low-effort.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/pages/labels/components/TeamNameField/TeamNameField.tsx` around lines 9 - 15, Rename the TeamNameField component and its props interface to FleetNameField (e.g., change TeamNameField -> FleetNameField and ITeamNameFieldProps -> IFleetNameFieldProps) and update its export, the component declaration, and the single import site in LabelForm.tsx so the displayed label and file name match; ensure any prop usages (the name prop) remain unchanged and update the filename to TeamNameField.tsx -> FleetNameField.tsx to keep module identity consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@frontend/pages/labels/components/LabelForm/LabelForm.tests.tsx`:
- Around line 106-125: The test "should render correct immutable help text for
two fields (DynamicLabelForm without fleet)" declares immutableFields and then
asserts immutableFields.length, which is vacuous; remove the line
expect(immutableFields.length).toBe(2) from LabelForm.tests.tsx so the test only
asserts the rendered output from the LabelForm component (keep the render call
and the screen.getByText assertion that checks the immutable help text).
In `@frontend/pages/labels/components/TeamNameField/TeamNameField.tsx`:
- Around line 9-15: Rename the TeamNameField component and its props interface
to FleetNameField (e.g., change TeamNameField -> FleetNameField and
ITeamNameFieldProps -> IFleetNameFieldProps) and update its export, the
component declaration, and the single import site in LabelForm.tsx so the
displayed label and file name match; ensure any prop usages (the name prop)
remain unchanged and update the filename to TeamNameField.tsx ->
FleetNameField.tsx to keep module identity consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9dc62fd9-9e40-4e83-a4ad-09e7c25ff23f
📒 Files selected for processing (5)
changes/labelform-use-fleets-and-reportsfrontend/pages/labels/components/DynamicLabelForm/DynamicLabelForm.tsxfrontend/pages/labels/components/LabelForm/LabelForm.tests.tsxfrontend/pages/labels/components/ManualLabelForm/ManualLabelForm.tsxfrontend/pages/labels/components/TeamNameField/TeamNameField.tsx
There was a problem hiding this comment.
Pull request overview
Updates the label edit/create UI copy to use newer product terminology in the shared label form, mainly replacing user-facing references to teams with fleets and queries with reports.
Changes:
- Renamed the label form’s team field label from “Team” to “Fleet”.
- Updated immutable-help-text inputs so manual labels refer to “fleets” and dynamic labels refer to “reports”.
- Updated label form tests and added a changelog entry for the terminology change.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
frontend/pages/labels/components/TeamNameField/TeamNameField.tsx |
Renames the displayed field label from Team to Fleet. |
frontend/pages/labels/components/ManualLabelForm/ManualLabelForm.tsx |
Changes manual-label immutable copy token from teams to fleets. |
frontend/pages/labels/components/LabelForm/LabelForm.tests.tsx |
Updates expectations for the new immutable-help-text wording. |
frontend/pages/labels/components/DynamicLabelForm/DynamicLabelForm.tsx |
Changes dynamic-label immutable copy tokens from queries to reports, and teams to fleets. |
changes/labelform-use-fleets-and-reports |
Records the user-visible copy change in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nulmete
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44770 +/- ##
==========================================
+ Coverage 66.67% 66.68% +0.01%
==========================================
Files 2664 2715 +51
Lines 214655 216964 +2309
Branches 9878 10627 +749
==========================================
+ Hits 143125 144688 +1563
- Misses 58500 59241 +741
- Partials 13030 13035 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please create an issue for this and make the proper updates to the changes file? Thanks |
@juan-fdz-hawa updated 👍 |
Ad-hoc issue detected when reviewing #44410
Resolves: #45141
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Added/updated automated tests
QA'd all new/changed functionality manually
Before
After
Summary by CodeRabbit