Website: remove /meetups and update routes - #44701
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR removes the meetups feature: controller, frontend page registration, styles, view template, and the policy bypass entry. The Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
website/views/pages/docs/report-library.ejs (1)
49-77:⚠️ Potential issue | 🟠 MajorFix swapped data sources in Linux and Windows tabs.
The Linux tab (line 49) is iterating over
windowsReportswhen it should iterate overlinuxReports. The Windows tab (line 66) is iterating overlinuxReportswhen it should iterate overwindowsReports. This causes each tab to display the wrong platform's reports. Update the loops to match their respective platforms:Required fix
<div v-else-if="selectedPlatform === 'linux'"> <% // Linux policies (server-side-rendered) - for(let report of windowsReports) { + for(let report of linuxReports) { %><div v-else-if="selectedPlatform === 'windows'"> <% // Windows policies (server-side-rendered) - for(let report of linuxReports) { + for(let report of windowsReports) { %>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@website/views/pages/docs/report-library.ejs` around lines 49 - 77, The Linux and Windows tab loops are using the wrong data arrays; when selectedPlatform === 'linux' the template currently iterates over windowsReports and when selectedPlatform === 'windows' it iterates over linuxReports. Fix by swapping the iterated collections: in the block guarded by selectedPlatform === 'linux' iterate over linuxReports (for let report of linuxReports) and in the block guarded by selectedPlatform === 'windows' iterate over windowsReports (for let report of windowsReports), leaving the inner rendering (report.slug, report.name, report.description, animated-arrow-button) unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@website/views/pages/docs/report-library.ejs`:
- Around line 49-77: The Linux and Windows tab loops are using the wrong data
arrays; when selectedPlatform === 'linux' the template currently iterates over
windowsReports and when selectedPlatform === 'windows' it iterates over
linuxReports. Fix by swapping the iterated collections: in the block guarded by
selectedPlatform === 'linux' iterate over linuxReports (for let report of
linuxReports) and in the block guarded by selectedPlatform === 'windows' iterate
over windowsReports (for let report of windowsReports), leaving the inner
rendering (report.slug, report.name, report.description, animated-arrow-button)
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a032652f-730e-4570-aa9b-b9603c6499dc
📒 Files selected for processing (10)
website/api/controllers/view-meetups.jswebsite/assets/js/pages/meetups.page.jswebsite/assets/styles/importer.lesswebsite/assets/styles/pages/meetups.lesswebsite/config/policies.jswebsite/config/routes.jswebsite/views/layouts/layout.ejswebsite/views/pages/admin/query-generator.ejswebsite/views/pages/docs/report-library.ejswebsite/views/pages/meetups.ejs
💤 Files with no reviewable changes (7)
- website/assets/styles/importer.less
- website/views/layouts/layout.ejs
- website/views/pages/meetups.ejs
- website/api/controllers/view-meetups.js
- website/assets/styles/pages/meetups.less
- website/assets/js/pages/meetups.page.js
- website/config/policies.js
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes the standalone /meetups page and makes /query-generator the canonical public route for the query generator page.
Changes:
- Deletes the
/meetupspage and its supporting controller, JS, and styles, and adds a redirect to/gitops-workshop. - Switches the query generator route back to
/query-generatorand updates related copy from “report robot” to “query robot”. - Removes meetups-specific asset loading and policy wiring.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
website/views/pages/meetups.ejs |
Removes the server-rendered meetups page markup. |
website/views/pages/docs/report-library.ejs |
Updates report-library copy to reference the query robot. |
website/views/pages/admin/query-generator.ejs |
Renames on-page query generator copy and error text. |
website/views/layouts/layout.ejs |
Removes the deleted meetups page script include. |
website/config/routes.js |
Replaces the query generator route and adds the /meetups redirect. |
website/config/policies.js |
Removes the deleted meetups controller policy entry. |
website/assets/styles/pages/meetups.less |
Deletes meetups-specific styles. |
website/assets/styles/importer.less |
Stops importing the deleted meetups stylesheet. |
website/assets/js/pages/meetups.page.js |
Deletes the meetups page Parasails module. |
website/api/controllers/view-meetups.js |
Removes the deleted meetups page controller. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes:
Summary by CodeRabbit
Removed Features
Updates