Skip to content

Fix lint issue in checkerboard viz - #44510

Merged
sgress454 merged 1 commit into
mainfrom
sgress454/fix-checkerboard-lint
Apr 30, 2026
Merged

Fix lint issue in checkerboard viz#44510
sgress454 merged 1 commit into
mainfrom
sgress454/fix-checkerboard-lint

Conversation

@sgress454

@sgress454 sgress454 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Fixes a lint issue in (currently unused) code for the 24-hr checkerboard, that was causing one of our build tests to fail.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced 24-hour checkerboard visualization tooltips to display complete data values and totals alongside percentage information.

Copilot AI review requested due to automatic review settings April 30, 2026 17:09
@sgress454
sgress454 requested a review from a team as a code owner April 30, 2026 17:09

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a TypeScript/lint failure in the (currently unused) 24-hour checkerboard visualization by ensuring the 24h cell objects conform to the ICellData shape used elsewhere in the component and by the tooltip.

Changes:

  • Include value and total when constructing ICellData for the 24h view so required fields are present.
  • Align 24h cell construction with multi-day cell construction for tooltip consumption (hoveredCell.value / hoveredCell.total).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.75%. Comparing base (13cec63) to head (00e1b21).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #44510      +/-   ##
==========================================
- Coverage   66.79%   66.75%   -0.04%     
==========================================
  Files        2637     2636       -1     
  Lines      212132   211707     -425     
  Branches     9555     9556       +1     
==========================================
- Hits       141690   141332     -358     
+ Misses      57576    57531      -45     
+ Partials    12866    12844      -22     
Flag Coverage Δ
frontend 54.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8f272750-0460-4d96-a0d2-f0119bcecb2f

📥 Commits

Reviewing files that changed from the base of the PR and between 13cec63 and 00e1b21.

📒 Files selected for processing (1)
  • frontend/pages/DashboardPage/cards/ChartCard/CheckerboardViz.tsx

Walkthrough

The CheckerboardViz component in the dashboard's chart card was modified to update cell data population for 24-hour mode (selectedDays === 1). The component now populates the ICellData.value and ICellData.total fields from incoming point data when building cells. Previously, these fields were not populated for 24-hour cells, with only percentage and labels being set. This change makes value and total data available for tooltip rendering when a tooltipFormatter is provided.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but sufficient for a lint fix. However, it does not follow the repository's required template structure with sections and checklists. Consider following the full PR template with relevant checklist sections, though for minor lint fixes a shorter description may be acceptable if agreed upon by maintainers.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a lint issue in the checkerboard visualization component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgress454/fix-checkerboard-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sgress454
sgress454 merged commit 56a8bc0 into main Apr 30, 2026
28 checks passed
@sgress454
sgress454 deleted the sgress454/fix-checkerboard-lint branch April 30, 2026 17:27
@coderabbitai coderabbitai Bot mentioned this pull request May 6, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants