Fix lint issue in checkerboard viz - #44510
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Fixes a TypeScript/lint failure in the (currently unused) 24-hour checkerboard visualization by ensuring the 24h cell objects conform to the ICellData shape used elsewhere in the component and by the tooltip.
Changes:
- Include
valueandtotalwhen constructingICellDatafor the 24h view so required fields are present. - Align 24h cell construction with multi-day cell construction for tooltip consumption (
hoveredCell.value/hoveredCell.total).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44510 +/- ##
==========================================
- Coverage 66.79% 66.75% -0.04%
==========================================
Files 2637 2636 -1
Lines 212132 211707 -425
Branches 9555 9556 +1
==========================================
- Hits 141690 141332 -358
+ Misses 57576 57531 -45
+ Partials 12866 12844 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CheckerboardViz component in the dashboard's chart card was modified to update cell data population for 24-hour mode (selectedDays === 1). The component now populates the ICellData.value and ICellData.total fields from incoming point data when building cells. Previously, these fields were not populated for 24-hour cells, with only percentage and labels being set. This change makes value and total data available for tooltip rendering when a tooltipFormatter is provided. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Fixes a lint issue in (currently unused) code for the 24-hr checkerboard, that was causing one of our build tests to fail.
Summary by CodeRabbit