Skip to content

fleetctl new: Update automatic enrollment profile - #44441

Merged
MagnusHJensen merged 3 commits into
mainfrom
dep-profile-template
May 1, 2026
Merged

fleetctl new: Update automatic enrollment profile#44441
MagnusHJensen merged 3 commits into
mainfrom
dep-profile-template

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Apr 29, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Configuration Updates

    • Updated the default macOS enrollment profile name to "Fleet default enrollment profile."
    • Enrollment onboarding now shows the full setup flow (no setup items are auto-skipped).
    • Removed region-specific configuration constraints.
  • Behavioral Changes

    • MDM profile can be removed after enrollment.

@noahtalerman
noahtalerman requested a review from a team as a code owner April 29, 2026 19:55

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@noahtalerman

Copy link
Copy Markdown
Member Author

FYI @sgress454

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3cecf8f0-8b15-4e11-8235-1157e8518ab7

📥 Commits

Reviewing files that changed from the base of the PR and between 1625a31 and 4c69f9f.

📒 Files selected for processing (1)
  • cmd/fleetctl/fleetctl/templates/new/platforms/macos/enrollment-profiles/automatic-enrollment.dep.json

Walkthrough

The macOS automatic enrollment profile template JSON was updated: profile_name changed to "Fleet default enrollment profile"; the fields allow_pairing, org_magic, language, and region were removed; and skip_setup_items was replaced with an empty array (no setup items skipped). No other file-level changes are reported.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides the related issue (#40905) and context, but is missing the required checklist items and doesn't follow the template structure with sections like Testing, Database migrations, etc. Add the standard PR checklist items from the template. At minimum, indicate whether changes files were added and whether testing was performed. Remove or complete the checklist sections as applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fleetctl new: Update automatic enrollment profile' clearly and specifically describes the main change of updating the automatic enrollment profile template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dep-profile-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

MagnusHJensen
MagnusHJensen previously approved these changes Apr 29, 2026
@noahtalerman
noahtalerman marked this pull request as draft April 30, 2026 12:56
@MagnusHJensen

Copy link
Copy Markdown
Member

This should also update the in-code profile, and make sure to update the docs-4.86 with the new example response (which is just what we provide in-code, and now this file) to ensure it aligns.

@MagnusHJensen MagnusHJensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment from yesterday

@MagnusHJensen

Copy link
Copy Markdown
Member

@noahtalerman I'll approve and merge this, and then do a different approach in code to avoid difference in the future.

@MagnusHJensen
MagnusHJensen merged commit 8755a4d into main May 1, 2026
9 checks passed
@MagnusHJensen
MagnusHJensen deleted the dep-profile-template branch May 1, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants