Skip to content

Cherry-pick #44329: Fix some bugs in charts UI - #44387

Merged
sgress454 merged 1 commit into
rc-minor-fleet-v4.85.0from
sgress454/fix-charts-ui-bugs-cp
Apr 29, 2026
Merged

Cherry-pick #44329: Fix some bugs in charts UI#44387
sgress454 merged 1 commit into
rc-minor-fleet-v4.85.0from
sgress454/fix-charts-ui-bugs-cp

Conversation

@sgress454

Copy link
Copy Markdown
Contributor

Cherry-pick of #44329 into the RC branch.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #44249

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
n/a, unreleased

## Testing

- [ ] Added/updated automated tests
not worth it for style fixes and accidental content removal
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [X] QA'd all new/changed functionality manually
- [X] can click on hosts enrolled labels and bars to go to the
appropriate hosts list
  - [X] no more weird focus rectangles on hosts enrolled chart
  - [X] hosts enrolled chart y-axis respects dark mode
  - [X] metrics cards returned to dashboard
- [X] hovering over a bar on the hosts enrolled chart shows a tooltip
with the # of hosts in that platform

For unreleased bug fixes in a release candidate, one of:

- [X] Confirmed that the fix is not expected to adversely impact load
test results


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Hosts Enrolled card: click platform bars or Y-axis labels to navigate
to platform-specific host lists; interactive tooltips show platform and
host count.

* **UI Improvements**
* Streamlined dashboard host-count display with a small loading spinner
while summaries load.
* Improved interactivity cues: hover styles, pointer cursor, and refined
tooltip visuals for chart elements.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@sgress454
sgress454 requested a review from a team as a code owner April 29, 2026 15:17

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.72%. Comparing base (9de8af6) to head (0b9ae7a).
⚠️ Report is 8 commits behind head on rc-minor-fleet-v4.85.0.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           rc-minor-fleet-v4.85.0   #44387      +/-   ##
==========================================================
- Coverage                   66.72%   66.72%   -0.01%     
==========================================================
  Files                        2626     2626              
  Lines                      211198   211189       -9     
  Branches                     9428     9547     +119     
==========================================================
- Hits                       140924   140915       -9     
  Misses                      57485    57485              
  Partials                    12789    12789              
Flag Coverage Δ
frontend 54.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454
sgress454 merged commit e41bdac into rc-minor-fleet-v4.85.0 Apr 29, 2026
16 checks passed
@sgress454
sgress454 deleted the sgress454/fix-charts-ui-bugs-cp branch April 29, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants