Skip to content

Cherry-pick #44373: Fix issue with fleet's docker image in k8s environments - #44381

Merged
lucasmrod merged 1 commit into
rc-minor-fleet-v4.85.0from
lucasmrod/fix-docker-image-k8s-cp
Apr 29, 2026
Merged

Cherry-pick #44373: Fix issue with fleet's docker image in k8s environments#44381
lucasmrod merged 1 commit into
rc-minor-fleet-v4.85.0from
lucasmrod/fix-docker-image-k8s-cp

Conversation

@lucasmrod

Copy link
Copy Markdown
Member

Cherry-pick of #44373 into the RC branch.

Resolves #44298

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

## Testing

- [X] QA'd all new/changed functionality manually

1. Running the docker image pushed by this PR with the user 3333 doesn't
fail anymore:
```sh
docker run --platform linux/amd64 -it --user 3333:3333 fleetdm/fleet@sha256:1a06bcae25e13e37f871378c7c156f5a2cdf67bc3c3e3bcdc95b6afc0c6decbb
[...]
ts=2026-04-29T13:25:56Z level=warn msg="could not connect to db" err="dial tcp [::1]:3306: connect: connection refused" sleep_interval=0s
[...]
```
4.84.0 fails with:
```sh
docker run --platform linux/amd64 -it --user 3333:3333 fleetdm/fleet:v4.84.0@sha256:51b56ad59a840b28e074ff9b06d6d5b232b0ca2f0d999bb164820da69c7cbe15

Failed to fetch user info for home directory: user: unknown userid 33332026/04/29 13:28:08 71 <nil>
```
2. `strings ./build/fleet | rg github.com/AbGuthrie/goquery/v2` returns
nothing in this branch and returns plenty of matches in `main`.
3. Smoke tested `fleetctl goquery` functionality.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Resolved Docker image startup failures in Kubernetes environments
caused by a dependency side effect.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@lucasmrod
lucasmrod requested a review from a team as a code owner April 29, 2026 14:20

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.79%. Comparing base (9de8af6) to head (915e8ca).
⚠️ Report is 5 commits behind head on rc-minor-fleet-v4.85.0.

Files with missing lines Patch % Lines
cmd/fleetctl/fleetctl/goquerycmd/goquery.go 0.00% 50 Missing ⚠️
cmd/fleetctl/fleetctl/goquery.go 0.00% 6 Missing ⚠️
cmd/fleetctl/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           rc-minor-fleet-v4.85.0   #44381      +/-   ##
==========================================================
+ Coverage                   66.72%   66.79%   +0.06%     
==========================================================
  Files                        2626     2627       +1     
  Lines                      211198   211233      +35     
  Branches                     9428     9428              
==========================================================
+ Hits                       140924   141085     +161     
+ Misses                      57485    57336     -149     
- Partials                    12789    12812      +23     
Flag Coverage Δ
backend 68.57% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucasmrod
lucasmrod merged commit 8de1573 into rc-minor-fleet-v4.85.0 Apr 29, 2026
51 checks passed
@lucasmrod
lucasmrod deleted the lucasmrod/fix-docker-image-k8s-cp branch April 29, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants