Upgrade fork-ts-checker-webpack-plugin - #44304
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
WalkthroughThis pull request makes targeted refinements across the frontend codebase and dependencies. It removes the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the frontend build toolchain to restore TypeScript type-checking during webpack builds by upgrading fork-ts-checker-webpack-plugin, and fixes newly-surfaced TS errors due to prior component API changes (EmptyState redesign and PoliciesCard prop updates).
Changes:
- Bump
fork-ts-checker-webpack-pluginfrom6.5.0to9.1.0(and refresh lockfile dependencies). - Remove usage of deprecated
<EmptyState>graphicName-related fields in queries/packs tables. - Remove deprecated
routerprop passed into<PoliciesCard>on the host details page.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Upgrades fork-ts-checker-webpack-plugin to 9.1.0. |
yarn.lock |
Updates resolved dependency graph for the upgraded plugin and transitive packages. |
frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx |
Removes deletion of now-nonexistent graphicName from empty state params. |
frontend/pages/packs/ManagePacksPage/components/PacksTable/PacksTable.tsx |
Removes graphicName-related empty state logic and stops passing graphicName to <EmptyState>. |
frontend/pages/hosts/details/HostDetailsPage/HostDetailsPage.tsx |
Removes deprecated router prop from <PoliciesCard>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44304 +/- ##
==========================================
- Coverage 66.77% 66.77% -0.01%
==========================================
Files 2630 2630
Lines 211248 211247 -1
Branches 9428 9428
==========================================
- Hits 141071 141070 -1
Misses 57354 57354
Partials 12823 12823
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves #44301
This PR updates the
fork-ts-checker-webpack-pluginto resolve the errors we were seeing when running it. Since it now runs cleanly, it identified a few typescript errors that need to be resolved at the same time:<EmptyState>no longer takes agraphicNameparam since it's been redesigned in Fleet UI: New empty states #43896<PoliciesCard>was reworked in Frontend: Lint warning cleanup part 1 #43411 and no longer takesrouter.I verified that this compiles cleanly in
make generateandmake generate-dev.Summary by CodeRabbit
Refactor
Chores