Skip to content

Upgrade fork-ts-checker-webpack-plugin - #44304

Merged
sgress454 merged 1 commit into
mainfrom
sgress454/fix-ts-warnings
Apr 28, 2026
Merged

Upgrade fork-ts-checker-webpack-plugin#44304
sgress454 merged 1 commit into
mainfrom
sgress454/fix-ts-warnings

Conversation

@sgress454

@sgress454 sgress454 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Resolves #44301

This PR updates the fork-ts-checker-webpack-plugin to resolve the errors we were seeing when running it. Since it now runs cleanly, it identified a few typescript errors that need to be resolved at the same time:

I verified that this compiles cleanly in make generate and make generate-dev.

Summary by CodeRabbit

  • Refactor

    • Simplified component properties and prop handling across host details, packs, and queries pages.
    • Refined empty-state configuration in packs management and queries tables.
  • Chores

    • Updated development build tool dependency from version 6.5.0 to 9.1.0 for TypeScript type-checking integration.

Copilot AI review requested due to automatic review settings April 28, 2026 17:17
@sgress454
sgress454 requested a review from a team as a code owner April 28, 2026 17:17

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e5897256-2f36-45e7-b8e7-e52b6d11d36e

📥 Commits

Reviewing files that changed from the base of the PR and between a360162 and b29e26a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • frontend/pages/hosts/details/HostDetailsPage/HostDetailsPage.tsx
  • frontend/pages/packs/ManagePacksPage/components/PacksTable/PacksTable.tsx
  • frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx
  • package.json
💤 Files with no reviewable changes (3)
  • frontend/pages/hosts/details/HostDetailsPage/HostDetailsPage.tsx
  • frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx
  • frontend/pages/packs/ManagePacksPage/components/PacksTable/PacksTable.tsx

Walkthrough

This pull request makes targeted refinements across the frontend codebase and dependencies. It removes the router prop from the PoliciesCard component in the host details page, eliminating reliance on a graphicName field from empty-state configurations in both the packs and queries table components, and upgrades the fork-ts-checker-webpack-plugin development dependency from version 6.5.0 to 9.1.0 to resolve a TypeScript performance profiling compatibility issue that was interfering with type-checking during webpack builds.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading the fork-ts-checker-webpack-plugin dependency.
Description check ✅ Passed The description explains the purpose (resolving #44301), the changes made (upgrading the plugin and fixing resulting TypeScript errors), and verification steps.
Linked Issues check ✅ Passed The PR fully addresses #44301 by upgrading fork-ts-checker-webpack-plugin from 6.5.0 to 9.1.0 and fixing the TypeScript errors it surfaced.
Out of Scope Changes check ✅ Passed All changes are in scope: the dependency upgrade and the necessary TypeScript error fixes in HostDetailsPage, PacksTable, and QueriesTable components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgress454/fix-ts-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the frontend build toolchain to restore TypeScript type-checking during webpack builds by upgrading fork-ts-checker-webpack-plugin, and fixes newly-surfaced TS errors due to prior component API changes (EmptyState redesign and PoliciesCard prop updates).

Changes:

  • Bump fork-ts-checker-webpack-plugin from 6.5.0 to 9.1.0 (and refresh lockfile dependencies).
  • Remove usage of deprecated <EmptyState> graphicName-related fields in queries/packs tables.
  • Remove deprecated router prop passed into <PoliciesCard> on the host details page.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Upgrades fork-ts-checker-webpack-plugin to 9.1.0.
yarn.lock Updates resolved dependency graph for the upgraded plugin and transitive packages.
frontend/pages/queries/ManageQueriesPage/components/QueriesTable/QueriesTable.tsx Removes deletion of now-nonexistent graphicName from empty state params.
frontend/pages/packs/ManagePacksPage/components/PacksTable/PacksTable.tsx Removes graphicName-related empty state logic and stops passing graphicName to <EmptyState>.
frontend/pages/hosts/details/HostDetailsPage/HostDetailsPage.tsx Removes deprecated router prop from <PoliciesCard>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.77%. Comparing base (c7673a2) to head (b29e26a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #44304      +/-   ##
==========================================
- Coverage   66.77%   66.77%   -0.01%     
==========================================
  Files        2630     2630              
  Lines      211248   211247       -1     
  Branches     9428     9428              
==========================================
- Hits       141071   141070       -1     
  Misses      57354    57354              
  Partials    12823    12823              
Flag Coverage Δ
frontend 54.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454
sgress454 merged commit 9609f0a into main Apr 28, 2026
23 checks passed
@sgress454
sgress454 deleted the sgress454/fix-ts-warnings branch April 28, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade fork-ts-checker-webpack-plugin

4 participants