Revert "Partial revert of #38785 work-in-progress (#44061)"

[getvictor]

This reverts commit 5b82531.

Related issue: Resolves #38785

Summary by CodeRabbit

Release Notes

• New Features

  • Windows setup experience now supports requiring all software installations: enrollment can be configured to cancel if any required software fails to install.

• Tests

  • Added test coverage for platform-specific setup software requirements.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d7a1bf50-647d-4da7-b850-ec5c405f8308

📥 Commits

Reviewing files that changed from the base of the PR and between 37b8e54 and 17a8bbf.

📒 Files selected for processing (3)

• changes/38785-windows-setup-experience-cancel
• server/service/setup_experience.go
• server/service/setup_experience_test.go

---

Walkthrough

The changes introduce a new require_all_software_windows setting for Windows Autopilot enrollment that cancels the setup experience if software installation fails, mirroring the existing macOS behavior. The implementation gates the "all software required" and setup experience cancellation logic to only run on macOS and Windows platforms, returning platform-specific configuration values from a mocked datastore. Test coverage is added to verify the function returns correct configuration values for each platform.

Possibly related PRs

• Partial revert of #38785 work-in-progress #44061 - Partially reverts Windows-specific setup-experience changes including RequireAllSoftwareWindows handling and related tests
• Add require_all_software_windows config option #43011 - Implements the same Windows "require all software" feature by adding RequireAllSoftwareWindows to configuration and wiring it into setup experience logic

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description is minimal but includes the revert commit hash and related issue reference, though it lacks details about testing and validation from the template.	Consider adding more context about what is being reverted and why, or confirm that the minimal format is acceptable for revert PRs.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the PR's main action: reverting a previous partial revert, which clearly summarizes the changeset's primary objective.
Linked Issues check	✅ Passed	The code changes implement the Windows setup experience cancellation feature when software fails, directly fulfilling the #38785 goal of achieving Windows parity with macOS behavior for critical software failures.
Out of Scope Changes check	✅ Passed	All changes are narrowly scoped to implementing the Windows-specific setup experience logic and corresponding tests, with no extraneous modifications outside the linked issue objectives.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch unrevert-38785-windows-setup-experience

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Re-enables/adjusts Windows “cancel setup experience if software fails” behavior by updating the setup experience service logic to treat Windows similarly to macOS, and adds coverage to validate correct config-field selection.

Changes:

• Update isAllSetupExperienceSoftwareRequired to gate behavior to macOS/Windows and read the correct config field for Windows (RequireAllSoftwareWindows) vs macOS.
• Update cancellation logic to allow Windows hosts to trigger cancellation of pending setup experience steps.
• Add unit tests covering global/team config selection for macOS vs Windows and non-supported platforms, plus a changelog entry.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
server/service/setup_experience.go	Gates cancel-on-failure behavior to darwin/windows and reads the appropriate per-platform config field; allows Windows cancellation flow.
server/service/setup_experience_test.go	Adds unit tests verifying macOS vs Windows config selection (global vs team) and unsupported platform behavior.
changes/38785-windows-setup-experience-cancel	Adds a release-note entry for require_all_software_windows.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.78%. Comparing base (37b8e54) to head (17a8bbf).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
server/service/setup_experience.go	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #44285   +/-   ##
=======================================
  Coverage   66.77%   66.78%           
=======================================
  Files        2630     2630           
  Lines      211248   211301   +53     
  Branches     9428     9428           
=======================================
+ Hits       141071   141127   +56     
+ Misses      57354    57351    -3     
  Partials    12823    12823           

Flag	Coverage Δ
backend	68.57% <83.33%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.