Skip to content

Disable 1Password auto-install and patch checks - #44181

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-fixing-1password
Apr 25, 2026
Merged

Disable 1Password auto-install and patch checks#44181
allenhouchins merged 1 commit into
mainfrom
allenhouchins-fixing-1password

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Apr 25, 2026

Copy link
Copy Markdown
Member

Comment out 1Password fleet-maintained app entries and related install/patch policies for macOS and Windows. Updates remove/disable the fleet_maintained_app references in it-and-security/fleets/workstations.yml and comment out install_software and patch entries in the macOS and Windows policy files to temporarily stop automatic installation and patch enforcement for 1Password.

Summary by CodeRabbit

  • Changes
    • 1Password management has been disabled across fleet workstations for both macOS and Windows platforms. Automatic installation and patching policies have been deactivated.

Comment out 1Password fleet-maintained app entries and related install/patch policies for macOS and Windows. Updates remove/disable the fleet_maintained_app references in it-and-security/fleets/workstations.yml and comment out install_software and patch entries in the macOS and Windows policy files to temporarily stop automatic installation and patch enforcement for 1Password.
@allenhouchins
allenhouchins marked this pull request as ready for review April 25, 2026 03:10
Copilot AI review requested due to automatic review settings April 25, 2026 03:10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenhouchins
allenhouchins merged commit caef460 into main Apr 25, 2026
4 of 5 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-fixing-1password branch April 25, 2026 03:10
@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 262133d0-f71e-4e3b-8e89-4cc12ef77234

📥 Commits

Reviewing files that changed from the base of the PR and between 93a2543 and 60339b1.

📒 Files selected for processing (5)
  • it-and-security/fleets/workstations.yml
  • it-and-security/lib/macos/policies/1password-installed.yml
  • it-and-security/lib/macos/policies/patch-fleet-maintained-apps.yml
  • it-and-security/lib/windows/policies/1password-installed.yml
  • it-and-security/lib/windows/policies/patch-fleet-maintained-apps.yml

Walkthrough

This pull request disables 1Password as a Fleet-maintained application across macOS and Windows platforms. The changes comment out 1Password entries in the fleet-maintained apps manifest, disable automatic installation remediation in both platform-specific 1Password-installed policies, and comment out the patch policies responsible for keeping 1Password updated on hosts labeled with the application.

Possibly related PRs

  • fleetdm/fleet#43611: Disables 1Password FMA patch and policy behavior by commenting entries in the same policy files and manifest configurations.
  • fleetdm/fleet#43752: Applies the same pattern of disabling Fleet-maintained app entries and associated patch policies across fleet and policy files for different applications.
  • fleetdm/fleet#43849: Modifies 1Password darwin maintained-app configuration, directly interacting with the same 1Password FMA component being disabled in this PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-fixing-1password

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants