Adding changes for Fleet v4.84.0 (#43092) - #44174
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the Fleet v4.84.0 release by bumping version references across tooling/deploy artifacts and consolidating release notes into CHANGELOG.md.
Changes:
- Bump Fleet version references to v4.84.0 (CLI installer, Helm chart, Terraform defaults, gm usage text).
- Update Helm chart version/appVersion for the new Fleet release.
- Move release-note fragments into
CHANGELOG.mdand remove the individualchanges/*entries.
Reviewed changes
Copilot reviewed 7 out of 105 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/github-manage/cmd/gm/releases.go | Updates milestone example/help text to Fleet 4.84.0. |
| tools/fleetctl-npm/package.json | Bumps fleetctl installer version to v4.84.0. |
| infrastructure/dogfood/terraform/gcp/variables.tf | Updates default Fleet image tag to v4.84.0 (but currently breaks Terraform syntax). |
| infrastructure/dogfood/terraform/aws/variables.tf | Updates default Fleet image tag to v4.84.0. |
| charts/fleet/values.yaml | Updates default deployed Fleet imageTag to v4.84.0. |
| charts/fleet/Chart.yaml | Bumps chart version and appVersion for Fleet v4.84.0. |
| CHANGELOG.md | Adds Fleet 4.84.0 release notes at the top. |
| changes/update-go-1.26.1 | Removes change fragment (now represented in CHANGELOG.md). |
| changes/up-default-software-batch | Removes change fragment (now represented in CHANGELOG.md). |
| changes/refactor-named-functions-nil-checks | Removes change fragment (now represented in CHANGELOG.md). |
| changes/issue-40076-clear-enrolled-from-migration | Removes change fragment (now represented in CHANGELOG.md). |
| changes/bump-mysql-8.0.42 | Removes change fragment (now represented in CHANGELOG.md). |
| changes/allow-clearing-windows-update-settings | Removes change fragment (now represented in CHANGELOG.md). |
| changes/add-api-time-on-gitops-errors | Removes change fragment (now represented in CHANGELOG.md). |
| changes/43977-fix-chg-mgmt-focus-issue | Removes change fragment (now represented in CHANGELOG.md). |
| changes/43875-windows-mdm-pending-commands-flood | Removes change fragment (now represented in CHANGELOG.md). |
| changes/43786-recovery-lock-reenroll-desync | Removes change fragment (now represented in CHANGELOG.md). |
| changes/43125-reports-nav-underline | Removes change fragment (now represented in CHANGELOG.md). |
| changes/43034-optimize-policy-queries-for-host | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42991-patch-policy-gitops-bug | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42836-deduplicate-flipping-policies-queries | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42814-sso-learn-more-link | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42808-rwmutex-jitter-shouldupdate | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42799-option-to-unlock-not-available-afler-lock | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42600-android-cert-templates-cleared-on-reenroll | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42572-fix-duplicate-text | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42545-windows-mdm-profile-summary-performance | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42443-fix-show-disk-encryption-key-modal | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42402-fix-query-results-deduplication | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42399-support-vpp-policy-automations-in-generate-gitops | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42383-android-display-name | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42327-apple-profile-retries | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42185-add-flatcar-coreos-linux-platforms | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42047-android-web-app-banner | Removes change fragment (now represented in CHANGELOG.md). |
| changes/42017-host-details-reports-tab | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41888-otel-service-name | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41815-override-patch-policy-query | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41778-fix-enqueue-setup-experience-items-for-arch-linux | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41742-fix-my-device-500-fleet-free | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41741-order | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41710-overwrite-software-title | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41672-allow-omitting-manual-hosts-label | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41670-auto-rotate-recovery-lock | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41644-improve-cpe-matching | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41636-typo-in-msrc-json | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41631-not-installed | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41603-fix-query-responses | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41601-use-multiplatform-names-in-front-end | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41586-admin-by-request-false-positive | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41542-android-cert-resend-backend | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41540-host-details-reports-db-optimizations | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41534-host-details-reports-api-end-point | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41500-validate-scripts | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41484-fix-windows-mdm-profile-upload-panic | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41409-use-fleetctl-new-templates-as-starter-lib | Removes change fragment (now represented in CHANGELOG.md). |
| changes/41324-support-labels-include-all-for-installers | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40972-policy-description | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40910-correct-request-certificate-pem | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40841-gitops-sw-upload-error | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40785-fix-gitops-vpp-token-assignment | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40751-google-drive-brew-version | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40715-allow-whitespace-end-users-form | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40581-os-versions-vuln-details | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40177-config-profile-name-status | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40137-update-default-fleet | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40117-fix-sql-table-alias-platform-detection | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40057-osv-vulns | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40050-server-core-msrc-differentiation | Removes change fragment (now represented in CHANGELOG.md). |
| changes/40015-activate-deprecation-warnings | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39968-sso-validity-increase-default | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39899-deterministic-cpe-matching | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39842-generate-gitops-bug | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39316-winoffice-vulnerability-detection | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39308-team-ca-read-access | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39190-display-sw-version-filter | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39082-setup-logo-light-background | Removes change fragment (now represented in CHANGELOG.md). |
| changes/39066-vpp-timeout-install-details | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38988-fma-pin-major-version | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38929-reports-tab | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38793-python-scripts | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38041-entra-windows-conditional-access | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38036-gitops-ca-delete-order | Removes change fragment (now represented in CHANGELOG.md). |
| changes/38002-throttle-ca-certificate-profiles | Removes change fragment (now represented in CHANGELOG.md). |
| changes/37556-resend-android-certs | Removes change fragment (now represented in CHANGELOG.md). |
| changes/37546-android-certificate-install-activity | Removes change fragment (now represented in CHANGELOG.md). |
| changes/37323-jetbrains-cve | Removes change fragment (now represented in CHANGELOG.md). |
| changes/36799-macos-disk-space-purgeable | Removes change fragment (now represented in CHANGELOG.md). |
| changes/36751-add-fmas-to-policy-automation | Removes change fragment (now represented in CHANGELOG.md). |
| changes/36643-fix-back-button-policies-reports | Removes change fragment (now represented in CHANGELOG.md). |
| changes/36312-trim-spaces-from-fleets-names | Removes change fragment (now represented in CHANGELOG.md). |
| changes/35484-improve-policy_membership-contention | Removes change fragment (now represented in CHANGELOG.md). |
| changes/35467-detail-query-config-preload | Removes change fragment (now represented in CHANGELOG.md). |
| changes/35067-windows-pro-missing-vulnerabilities | Removes change fragment (now represented in CHANGELOG.md). |
| changes/34950-nano-tables-cleanup | Removes change fragment (now represented in CHANGELOG.md). |
| changes/34667-scim-user-host-emails-association | Removes change fragment (now represented in CHANGELOG.md). |
| changes/34433-speedup-macos-profile-delivery | Removes change fragment (now represented in CHANGELOG.md). |
| changes/34288-setup-experience-cancel-activity | Removes change fragment (now represented in CHANGELOG.md). |
| changes/33418-windows-mdm-profile-deletion | Removes change fragment (now represented in CHANGELOG.md). |
| changes/33106-fix-generate-gitops-vpp | Removes change fragment (now represented in CHANGELOG.md). |
| changes/32773-preview-windows-mdm | Removes change fragment (now represented in CHANGELOG.md). |
| changes/32662-include-correct-cpe | Removes change fragment (now represented in CHANGELOG.md). |
| changes/32126-macos-fleetd-reinstall | Removes change fragment (now represented in CHANGELOG.md). |
| changes/31289-acme-for-mdm-protocol | Removes change fragment (now represented in CHANGELOG.md). |
| changes/29657-custom-settings-configuration-profiles | Removes change fragment (now represented in CHANGELOG.md). |
| changes/14827-prevent-TOCTOU-last-admin | Removes change fragment (now represented in CHANGELOG.md). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| variable "image" { | ||
| default = "fleetdm/fleet:v4.83.2" | ||
| } | ||
| default = "fleetdm/fleet:v4.84.0" | ||
|
|
||
| variable "software_installers_bucket_name" { |
There was a problem hiding this comment.
The variable "image" block is missing its closing }. As-is, this will make the Terraform file invalid (and will likely cause all following variable blocks to be parsed incorrectly). Add the closing brace after the default line and keep the blank line before the next variable declaration.
There was a problem hiding this comment.
Don't know how this happened. Fixed.
@rfairburn This will be correct on main but missing the closing tag in the tagged release. Does that matter?
There was a problem hiding this comment.
As long main main is what is used on the github action, we should be fine. Since this is GCP and the legacy terraform and not the primary fleet-terraform gcp module, I think it matters very little
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis pull request removes ~84 changelog/notes entries from the Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@infrastructure/dogfood/terraform/gcp/variables.tf`:
- Around line 70-73: The Terraform variable block for variable "image" is
missing its closing brace which breaks parsing; locate the variable "image"
block (the default = "fleetdm/fleet:v4.84.0") and add a closing brace right
after the default line so the block properly ends before the next variable
"software_installers_bucket_name" declaration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac53f657-3c11-4155-b2e4-e916e2fa966a
⛔ Files ignored due to path filters (1)
CHANGELOG.mdis excluded by!**/*.md
📒 Files selected for processing (104)
changes/14827-prevent-TOCTOU-last-adminchanges/29657-custom-settings-configuration-profileschanges/31289-acme-for-mdm-protocolchanges/32126-macos-fleetd-reinstallchanges/32662-include-correct-cpechanges/32773-preview-windows-mdmchanges/33106-fix-generate-gitops-vppchanges/33418-windows-mdm-profile-deletionchanges/34288-setup-experience-cancel-activitychanges/34433-speedup-macos-profile-deliverychanges/34667-scim-user-host-emails-associationchanges/34950-nano-tables-cleanupchanges/35067-windows-pro-missing-vulnerabilitieschanges/35467-detail-query-config-preloadchanges/35484-improve-policy_membership-contentionchanges/36312-trim-spaces-from-fleets-nameschanges/36643-fix-back-button-policies-reportschanges/36751-add-fmas-to-policy-automationchanges/36799-macos-disk-space-purgeablechanges/37323-jetbrains-cvechanges/37546-android-certificate-install-activitychanges/37556-resend-android-certschanges/38002-throttle-ca-certificate-profileschanges/38036-gitops-ca-delete-orderchanges/38041-entra-windows-conditional-accesschanges/38793-python-scriptschanges/38929-reports-tabchanges/38988-fma-pin-major-versionchanges/39066-vpp-timeout-install-detailschanges/39082-setup-logo-light-backgroundchanges/39190-display-sw-version-filterchanges/39308-team-ca-read-accesschanges/39316-winoffice-vulnerability-detectionchanges/39842-generate-gitops-bugchanges/39899-deterministic-cpe-matchingchanges/39968-sso-validity-increase-defaultchanges/40015-activate-deprecation-warningschanges/40050-server-core-msrc-differentiationchanges/40057-osv-vulnschanges/40117-fix-sql-table-alias-platform-detectionchanges/40137-update-default-fleetchanges/40177-config-profile-name-statuschanges/40581-os-versions-vuln-detailschanges/40715-allow-whitespace-end-users-formchanges/40751-google-drive-brew-versionchanges/40785-fix-gitops-vpp-token-assignmentchanges/40841-gitops-sw-upload-errorchanges/40910-correct-request-certificate-pemchanges/40972-policy-descriptionchanges/41324-support-labels-include-all-for-installerschanges/41409-use-fleetctl-new-templates-as-starter-libchanges/41484-fix-windows-mdm-profile-upload-panicchanges/41500-validate-scriptschanges/41534-host-details-reports-api-end-pointchanges/41540-host-details-reports-db-optimizationschanges/41542-android-cert-resend-backendchanges/41586-admin-by-request-false-positivechanges/41601-use-multiplatform-names-in-front-endchanges/41603-fix-query-responseschanges/41631-not-installedchanges/41636-typo-in-msrc-jsonchanges/41644-improve-cpe-matchingchanges/41670-auto-rotate-recovery-lockchanges/41672-allow-omitting-manual-hosts-labelchanges/41710-overwrite-software-titlechanges/41741-orderchanges/41742-fix-my-device-500-fleet-freechanges/41778-fix-enqueue-setup-experience-items-for-arch-linuxchanges/41815-override-patch-policy-querychanges/41888-otel-service-namechanges/42017-host-details-reports-tabchanges/42047-android-web-app-bannerchanges/42185-add-flatcar-coreos-linux-platformschanges/42327-apple-profile-retrieschanges/42383-android-display-namechanges/42399-support-vpp-policy-automations-in-generate-gitopschanges/42402-fix-query-results-deduplicationchanges/42443-fix-show-disk-encryption-key-modalchanges/42545-windows-mdm-profile-summary-performancechanges/42572-fix-duplicate-textchanges/42600-android-cert-templates-cleared-on-reenrollchanges/42799-option-to-unlock-not-available-afler-lockchanges/42808-rwmutex-jitter-shouldupdatechanges/42814-sso-learn-more-linkchanges/42836-deduplicate-flipping-policies-querieschanges/42991-patch-policy-gitops-bugchanges/43034-optimize-policy-queries-for-hostchanges/43125-reports-nav-underlinechanges/43786-recovery-lock-reenroll-desyncchanges/43875-windows-mdm-pending-commands-floodchanges/43977-fix-chg-mgmt-focus-issuechanges/add-api-time-on-gitops-errorschanges/allow-clearing-windows-update-settingschanges/bump-mysql-8.0.42changes/issue-40076-clear-enrolled-from-migrationchanges/refactor-named-functions-nil-checkschanges/up-default-software-batchchanges/update-go-1.26.1charts/fleet/Chart.yamlcharts/fleet/values.yamlinfrastructure/dogfood/terraform/aws/variables.tfinfrastructure/dogfood/terraform/gcp/variables.tftools/fleetctl-npm/package.jsontools/github-manage/cmd/gm/releases.go
💤 Files with no reviewable changes (98)
- changes/42814-sso-learn-more-link
- changes/40137-update-default-fleet
- changes/42443-fix-show-disk-encryption-key-modal
- changes/38036-gitops-ca-delete-order
- changes/36312-trim-spaces-from-fleets-names
- changes/42017-host-details-reports-tab
- changes/40015-activate-deprecation-warnings
- changes/40715-allow-whitespace-end-users-form
- changes/29657-custom-settings-configuration-profiles
- changes/41603-fix-query-responses
- changes/41324-support-labels-include-all-for-installers
- changes/allow-clearing-windows-update-settings
- changes/38041-entra-windows-conditional-access
- changes/41888-otel-service-name
- changes/35067-windows-pro-missing-vulnerabilities
- changes/41741-order
- changes/43125-reports-nav-underline
- changes/43977-fix-chg-mgmt-focus-issue
- changes/bump-mysql-8.0.42
- changes/42399-support-vpp-policy-automations-in-generate-gitops
- changes/41710-overwrite-software-title
- changes/36799-macos-disk-space-purgeable
- changes/32773-preview-windows-mdm
- changes/36643-fix-back-button-policies-reports
- changes/41409-use-fleetctl-new-templates-as-starter-lib
- changes/40910-correct-request-certificate-pem
- changes/42600-android-cert-templates-cleared-on-reenroll
- changes/39308-team-ca-read-access
- changes/up-default-software-batch
- changes/41636-typo-in-msrc-json
- changes/14827-prevent-TOCTOU-last-admin
- changes/add-api-time-on-gitops-errors
- changes/41542-android-cert-resend-backend
- changes/37323-jetbrains-cve
- changes/39190-display-sw-version-filter
- changes/36751-add-fmas-to-policy-automation
- changes/update-go-1.26.1
- changes/32662-include-correct-cpe
- changes/37556-resend-android-certs
- changes/39082-setup-logo-light-background
- changes/41601-use-multiplatform-names-in-front-end
- changes/41670-auto-rotate-recovery-lock
- changes/42799-option-to-unlock-not-available-afler-lock
- changes/34667-scim-user-host-emails-association
- changes/42991-patch-policy-gitops-bug
- changes/40972-policy-description
- changes/43875-windows-mdm-pending-commands-flood
- changes/42327-apple-profile-retries
- changes/42545-windows-mdm-profile-summary-performance
- changes/42383-android-display-name
- changes/38988-fma-pin-major-version
- changes/42047-android-web-app-banner
- changes/31289-acme-for-mdm-protocol
- changes/41742-fix-my-device-500-fleet-free
- changes/41586-admin-by-request-false-positive
- changes/43034-optimize-policy-queries-for-host
- changes/32126-macos-fleetd-reinstall
- changes/41631-not-installed
- changes/40057-osv-vulns
- changes/42185-add-flatcar-coreos-linux-platforms
- changes/42572-fix-duplicate-text
- changes/35484-improve-policy_membership-contention
- changes/42808-rwmutex-jitter-shouldupdate
- changes/43786-recovery-lock-reenroll-desync
- changes/39899-deterministic-cpe-matching
- changes/40177-config-profile-name-status
- changes/40050-server-core-msrc-differentiation
- changes/39968-sso-validity-increase-default
- changes/41500-validate-scripts
- changes/41534-host-details-reports-api-end-point
- changes/38793-python-scripts
- changes/40841-gitops-sw-upload-error
- changes/refactor-named-functions-nil-checks
- changes/34288-setup-experience-cancel-activity
- changes/41484-fix-windows-mdm-profile-upload-panic
- changes/35467-detail-query-config-preload
- changes/42836-deduplicate-flipping-policies-queries
- changes/33106-fix-generate-gitops-vpp
- changes/42402-fix-query-results-deduplication
- changes/39842-generate-gitops-bug
- changes/40117-fix-sql-table-alias-platform-detection
- changes/39316-winoffice-vulnerability-detection
- changes/41815-override-patch-policy-query
- changes/41540-host-details-reports-db-optimizations
- changes/issue-40076-clear-enrolled-from-migration
- changes/40751-google-drive-brew-version
- changes/34950-nano-tables-cleanup
- changes/41672-allow-omitting-manual-hosts-label
- changes/39066-vpp-timeout-install-details
- changes/38002-throttle-ca-certificate-profiles
- changes/41644-improve-cpe-matching
- changes/34433-speedup-macos-profile-delivery
- changes/37546-android-certificate-install-activity
- changes/41778-fix-enqueue-setup-experience-items-for-arch-linux
- changes/40785-fix-gitops-vpp-token-assignment
- changes/40581-os-versions-vuln-details
- changes/33418-windows-mdm-profile-deletion
- changes/38929-reports-tab
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44174 +/- ##
==========================================
+ Coverage 66.76% 66.78% +0.01%
==========================================
Files 2629 2627 -2
Lines 211215 211148 -67
Branches 9502 9502
==========================================
- Hits 141027 141014 -13
+ Misses 57362 57317 -45
+ Partials 12826 12817 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit