Skip to content

Cherry-pick #44094: Add activities when toggling GitOps exception settings - #44145

Merged
AndreyKizimenko merged 1 commit into
rc-minor-fleet-v4.84.0from
sgress454/gitops-exception-activities-cp
Apr 24, 2026
Merged

Cherry-pick #44094: Add activities when toggling GitOps exception settings#44145
AndreyKizimenko merged 1 commit into
rc-minor-fleet-v4.84.0from
sgress454/gitops-exception-activities-cp

Conversation

@sgress454

Copy link
Copy Markdown
Contributor

Cherry-pick of #44094 into the RC branch.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** For #40171

# Details

Adds audit activity when enabling or disabling GitOps exceptions.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
n/a, unreleased

## Testing

- [X] Added/updated automated tests
- [X] QA'd all new/changed functionality manually

<img width="714" height="699" alt="image"
src="https://github.com/user-attachments/assets/161bd084-347b-4cde-893e-9b385f13872c"
/>


For unreleased bug fixes in a release candidate, one of:

- [X] Confirmed that the fix is not expected to adversely impact load
test results


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Activity feed now records when GitOps exceptions (labels, software,
secrets) are enabled or disabled.
* **UI**
* Activity messages show which specific exception was enabled or
disabled.
* **Tests**
* Added unit and integration tests verifying generation and rendering of
enable/disable exception activities, including single and multiple flips
and no-op updates.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sgress454 <553428+sgress454@users.noreply.github.com>
Co-authored-by: Luke Heath <luke@fleetdm.com>
@sgress454
sgress454 requested review from a team and rachaelshaw as code owners April 24, 2026 18:11

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.84.0@ec76eec). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/appconfig.go 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.84.0   #44145   +/-   ##
=========================================================
  Coverage                          ?   66.88%           
=========================================================
  Files                             ?     2545           
  Lines                             ?   204627           
  Branches                          ?     9006           
=========================================================
  Hits                              ?   136874           
  Misses                            ?    55200           
  Partials                          ?    12553           
Flag Coverage Δ
backend 68.62% <90.00%> (?)
frontend 54.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndreyKizimenko
AndreyKizimenko merged commit c175335 into rc-minor-fleet-v4.84.0 Apr 24, 2026
52 checks passed
@AndreyKizimenko
AndreyKizimenko deleted the sgress454/gitops-exception-activities-cp branch April 24, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants