Update Fleet-maintained apps - #44119
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Script Diff Resultsee/maintained-apps/outputs/1password/windows.json=== Install Script (no changes) ===
=== Uninstall // 795667d8 -> 43b5726e ===
--- /tmp/old.Cvs1J3 2026-04-24 14:33:38.177105637 +0000
+++ /tmp/new.RfmfeU 2026-04-24 14:33:38.177105637 +0000
@@ -1,7 +1,7 @@
# 1Password Uninstall Script
# Closes running processes before uninstalling to prevent hangs
-$product_code = '{1D940C01-A867-4D52-AF26-026FD7EB6A41}'
+$product_code = '{4E29828B-8BA2-452F-91A1-D4294DC6C0A8}'
$timeoutSeconds = 300 # 5 minute timeout
# Close any running 1Password processesee/maintained-apps/outputs/adobe-acrobat-reader/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/arc/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/brave-browser/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/brave-browser/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/clion/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/clockify/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/goland/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/granola/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/granola/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-excel/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-onenote/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-outlook/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-powerpoint/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-word/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/miro/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/obs/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/ollama/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/ollama/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/opera/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/phpstorm/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/protonvpn/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/rubymine/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/rustrover/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/spotify/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/webstorm/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
WalkthroughThis pull request updates version metadata for 27 maintained applications across macOS and Windows platforms. Each update modifies the corresponding JSON configuration files to bump the application version, adjust the SQL Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ee/maintained-apps/outputs/spotify/darwin.json (1)
9-12:⚠️ Potential issue | 🟡 Minor"no_check" is a documented pattern for vendor URLs — consider SHA256 validation once available.
The
sha256: "no_check"field is intentional, following Homebrew's convention for apps distributed via direct vendor URLs (likehttps://download.scdn.co/SpotifyARM64.dmg) where hashes aren't stable or predictable. The system defers hash computation until after download rather than validating before installation.However, the version mismatch risk remains valid: the installer URL doesn't include a version number, so if Spotify's CDN serves a different version than
1.2.88.483(specified in theversionfield), installation will succeed without detection since there's no pre-installation hash validation. Consider:
- Adding a SHA256 hash if Spotify publishes official checksums for this specific version
- Documenting the CDN behavior (e.g., whether the URL serves the latest version or can be pinned)
- Adding post-installation version verification in the install script if the version field doesn't match the installed version
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ee/maintained-apps/outputs/spotify/darwin.json` around lines 9 - 12, The darwin.json entry uses sha256: "no_check" for the Spotify installer_url; update the package to either supply a real SHA256 when an official checksum for version "1.2.88.483" is available (replace the "sha256" value), or else document the CDN behavior and add a post-installation version verification in the install script referenced by "install_script_ref" (verify the installed app version matches the "version" field and fail/log if it doesn't); ensure changes reference the "installer_url", "sha256", "version", and "install_script_ref" fields so reviewers can locate and validate the fix.
🧹 Nitpick comments (1)
ee/maintained-apps/outputs/adobe-acrobat-reader/windows.json (1)
12-12: Validate the SHA-256 hash in CI or during ingestion against the downloaded installer.Since this is a security-sensitive integrity field, adding hash validation in your CI pipeline for this URL/version pair is recommended to ensure the installer hasn't been tampered with or corrupted during download.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ee/maintained-apps/outputs/adobe-acrobat-reader/windows.json` at line 12, Add a CI/ingestion check that downloads the installer for the given URL/version pair and computes its SHA-256, then compares it against the "sha256" value in the windows.json output for adobe-acrobat-reader; if the computed hash does not match the "sha256" field, fail the pipeline (or ingestion job), log the expected vs actual hash and URL/version, and optionally retry download before failing. Ensure this check runs as part of the artifact ingestion step (or a dedicated verify-sha256 job) so tampered or corrupted installers are detected early.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@ee/maintained-apps/outputs/spotify/darwin.json`:
- Around line 9-12: The darwin.json entry uses sha256: "no_check" for the
Spotify installer_url; update the package to either supply a real SHA256 when an
official checksum for version "1.2.88.483" is available (replace the "sha256"
value), or else document the CDN behavior and add a post-installation version
verification in the install script referenced by "install_script_ref" (verify
the installed app version matches the "version" field and fail/log if it
doesn't); ensure changes reference the "installer_url", "sha256", "version", and
"install_script_ref" fields so reviewers can locate and validate the fix.
---
Nitpick comments:
In `@ee/maintained-apps/outputs/adobe-acrobat-reader/windows.json`:
- Line 12: Add a CI/ingestion check that downloads the installer for the given
URL/version pair and computes its SHA-256, then compares it against the "sha256"
value in the windows.json output for adobe-acrobat-reader; if the computed hash
does not match the "sha256" field, fail the pipeline (or ingestion job), log the
expected vs actual hash and URL/version, and optionally retry download before
failing. Ensure this check runs as part of the artifact ingestion step (or a
dedicated verify-sha256 job) so tampered or corrupted installers are detected
early.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2ec2dd17-4c6c-4f97-aef5-6b803740b00b
📒 Files selected for processing (28)
ee/maintained-apps/outputs/1password/windows.jsonee/maintained-apps/outputs/adobe-acrobat-reader/windows.jsonee/maintained-apps/outputs/arc/darwin.jsonee/maintained-apps/outputs/brave-browser/darwin.jsonee/maintained-apps/outputs/brave-browser/windows.jsonee/maintained-apps/outputs/clion/darwin.jsonee/maintained-apps/outputs/clockify/darwin.jsonee/maintained-apps/outputs/goland/darwin.jsonee/maintained-apps/outputs/granola/darwin.jsonee/maintained-apps/outputs/granola/windows.jsonee/maintained-apps/outputs/microsoft-excel/darwin.jsonee/maintained-apps/outputs/microsoft-onenote/darwin.jsonee/maintained-apps/outputs/microsoft-outlook/darwin.jsonee/maintained-apps/outputs/microsoft-powerpoint/darwin.jsonee/maintained-apps/outputs/microsoft-word/darwin.jsonee/maintained-apps/outputs/miro/darwin.jsonee/maintained-apps/outputs/obs/windows.jsonee/maintained-apps/outputs/ollama/darwin.jsonee/maintained-apps/outputs/ollama/windows.jsonee/maintained-apps/outputs/opera/darwin.jsonee/maintained-apps/outputs/phpstorm/darwin.jsonee/maintained-apps/outputs/postman/darwin.jsonee/maintained-apps/outputs/postman/windows.jsonee/maintained-apps/outputs/protonvpn/darwin.jsonee/maintained-apps/outputs/rubymine/darwin.jsonee/maintained-apps/outputs/rustrover/darwin.jsonee/maintained-apps/outputs/spotify/darwin.jsonee/maintained-apps/outputs/webstorm/darwin.json
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit