Fleet UI: return app name on success of adding android app by RachelElysia · Pull Request #44068 · fleetdm/fleet

RachelElysia · 2026-04-23T17:46:06Z

Issue

Closes #44067

Description

Screenrecording

Before

Screen.Recording.2026-05-11.at.3.45.18.PM.mov

After

Screen.Recording.2026-05-11.at.3.48.39.PM.mov

Testing

Added/updated automated tests
QA'd all new/changed functionality manually

Summary by CodeRabbit

New Features
- The API for adding App Store apps now returns the application name alongside the software title ID in responses.
Tests
- Integration and unit tests updated to validate the returned app name for newly added apps and authorization flows.

codecov · 2026-04-23T17:49:19Z

Codecov Report

❌ Patch coverage is 43.58974% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.81%. Comparing base (6fa4d53) to head (a05d448).
⚠️ Report is 57 commits behind head on main.

Files with missing lines	Patch %	Lines
ee/server/service/vpp.go	42.85%	20 Missing ⚠️
server/service/vpp.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #44068      +/-   ##
==========================================
+ Coverage   66.78%   66.81%   +0.02%     
==========================================
  Files        2718     2722       +4     
  Lines      218772   218996     +224     
  Branches    10709    10709              
==========================================
+ Hits       146112   146313     +201     
- Misses      59497    59518      +21     
- Partials    13163    13165       +2

Flag	Coverage Δ
backend	`68.67% <43.58%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

coderabbitai · 2026-05-11T19:56:18Z

Caution

Review failed

An error occurred during the review process. Please try again later.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d45adcd6-7cb7-4cca-a20f-1a7a803a4907

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5321c and a05d448.

📒 Files selected for processing (1)

server/service/integration_android_software_test.go

Walkthrough

This PR extends the AddAppStoreApp method to return the app name alongside the software title ID. The interface signature changes from (uint, error) to (uint, string, error). The HTTP response struct gains a name field alongside software_title_id. The implementation updates all error paths to return an empty string for the name, while success returns the actual app name fetched from Android Play Store or Apple VPP metadata. Mock and test call sites are updated to handle the additional return value.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description is incomplete; it lacks detailed explanation of changes and only checks the testing boxes without properly filling the template.	Add a comprehensive 'Description' section explaining the changes made (adding app name to API response), and complete other relevant checklist items or remove them if not applicable.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: returning the app name on success when adding an Android app to improve the UI success message.
Linked Issues check	✅ Passed	The PR successfully implements the primary objective from `#44067`: returning the app name in the AddAppStoreApp response so the UI can display the human-readable app name in success messages.
Out of Scope Changes check	✅ Passed	All changes are scoped to returning the app name in the AddAppStoreApp method signature and related response updates; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 44067-android-app-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the VPP “add app store app” flow so the API returns the newly-added app’s name (in addition to the software title ID), enabling the Fleet UI to display the Android app name on success.

Changes:

Extended AddAppStoreApp service method to return (titleID, name, err).
Added name to the addAppStoreAppResponse JSON payload.
Updated affected unit tests and the service mock to match the new method signature.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
server/service/vpp.go	Extends endpoint response to include app name and updates service signature/stub.
ee/server/service/vpp.go	Updates EE implementation to return the app name along with the title ID.
server/fleet/service.go	Updates `Service` interface contract to return app name.
server/mock/service/service_mock.go	Updates mock function types/signatures for `AddAppStoreApp`.
server/service/vpp_test.go	Updates auth test to handle the new return value.
server/service/software_installers_test.go	Updates auth test to handle the new return value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RachelElysia · 2026-05-11T20:32:36Z

 			}

-			_, err = svc.AddAppStoreApp(ctx, tt.teamID, fleet.VPPAppTeam{VPPAppID: fleet.VPPAppID{AdamID: "123", Platform: fleet.IOSPlatform}})
+			_, _, err = svc.AddAppStoreApp(ctx, tt.teamID, fleet.VPPAppTeam{VPPAppID: fleet.VPPAppID{AdamID: "123", Platform: fleet.IOSPlatform}})


It's being tested elsewhere: server/service/integration_android_software_test.go in TestAndroidAppsSelfService, lines ~307 and ~392

RachelElysia · 2026-05-11T20:04:24Z

 	}

-	return addedApp.TitleID, nil
+	return addedApp.TitleID, app.Name, nil


Fleet's MySQL layer doesn't normalize VPP app names on insert (no triggers, no column transforms). The value you pass in is the value that gets stored. Adding a re-read after write is an extra DB round-trip to guard against something that doesn't happen.

jkatz01

Looks good!

jkatz01 · 2026-05-12T16:08:04Z

-	TitleID uint  `json:"software_title_id,omitempty"`
-	Err     error `json:"error,omitempty"`
+	TitleID uint   `json:"software_title_id,omitempty"`
+	Name    string `json:"name,omitempty"`


Do we need a docs update for this?

Will do separate PR into 4.86.0 docs

RachelElysia temporarily deployed to Docker Hub April 23, 2026 17:46 — with GitHub Actions Inactive

RachelElysia mentioned this pull request Apr 23, 2026

FE: Clean up lint warnings part III #44065

Merged

Rachel Perkins and others added 2 commits May 11, 2026 15:44

Fleet UI: return app name on success of adding android app

63cb222

Fix expected return

9c5321c

RachelElysia force-pushed the 44067-android-app-name branch from a765401 to 9c5321c Compare May 11, 2026 19:49

RachelElysia temporarily deployed to Docker Hub May 11, 2026 19:50 — with GitHub Actions Inactive

RachelElysia marked this pull request as ready for review May 11, 2026 19:52

RachelElysia requested a review from a team as a code owner May 11, 2026 19:52

Copilot AI review requested due to automatic review settings May 11, 2026 19:52

claude Bot reviewed May 11, 2026

View reviewed changes

Copilot AI reviewed May 11, 2026

View reviewed changes

Add tests

a05d448

RachelElysia temporarily deployed to Docker Hub May 11, 2026 20:07 — with GitHub Actions Inactive

Copilot started reviewing on behalf of RachelElysia May 11, 2026 20:14 View session

RachelElysia assigned jkatz01 and unassigned jkatz01 May 11, 2026

jkatz01 approved these changes May 12, 2026

View reviewed changes

jkatz01 reviewed May 12, 2026

View reviewed changes

RachelElysia merged commit 7e875ea into main May 12, 2026
56 checks passed

RachelElysia deleted the 44067-android-app-name branch May 12, 2026 17:51

coderabbitai Bot mentioned this pull request May 12, 2026

iOS/iPadOS managed config: service wiring (#43965) #44932

Merged

Navigation Menu

Uh oh!

Fleet UI: return app name on success of adding android app - #44068

Fleet UI: return app name on success of adding android app#44068
RachelElysia merged 3 commits into
mainfrom
44067-android-app-name

RachelElysia commented Apr 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

coderabbitai Bot commented May 11, 2026 •

edited

Loading

Review failed

❌ Failed checks (1 inconclusive)

Uh oh!

Copilot AI left a comment

Uh oh!

RachelElysia May 11, 2026

Uh oh!

RachelElysia May 11, 2026

Uh oh!

jkatz01 left a comment

Uh oh!

jkatz01 May 12, 2026

Uh oh!

RachelElysia May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

RachelElysia commented Apr 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Screenrecording

Before

After

Testing

Summary by CodeRabbit

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

coderabbitai Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

RachelElysia May 11, 2026

Choose a reason for hiding this comment

Uh oh!

RachelElysia May 11, 2026

Choose a reason for hiding this comment

Uh oh!

jkatz01 left a comment

Choose a reason for hiding this comment

Uh oh!

jkatz01 May 12, 2026

Choose a reason for hiding this comment

Uh oh!

RachelElysia May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RachelElysia commented Apr 23, 2026 •

edited by coderabbitai Bot

Loading

codecov Bot commented Apr 23, 2026 •

edited

Loading

coderabbitai Bot commented May 11, 2026 •

edited

Loading