Skip to content

Update class on exceptions field to fix padding - #43927

Merged
lukeheath merged 2 commits into
mainfrom
sgress454/43070-fix-exceptions-spacing
Apr 22, 2026
Merged

Update class on exceptions field to fix padding#43927
lukeheath merged 2 commits into
mainfrom
sgress454/43070-fix-exceptions-spacing

Conversation

@sgress454

@sgress454 sgress454 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #43070

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • QA'd all new/changed functionality manually

Before

image

After

image

Summary by CodeRabbit

  • Bug Fixes
    • Fixed padding between GitOps exceptions checkboxes in the Change Management section.

Copilot AI review requested due to automatic review settings April 21, 2026 21:55
@sgress454
sgress454 requested a review from a team as a code owner April 21, 2026 21:55

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 837b47ad-b455-4740-aa60-9905dc41b70e

📥 Commits

Reviewing files that changed from the base of the PR and between 1f6e556 and e23f596.

📒 Files selected for processing (2)
  • changes/43070-fix-exceptions-padding
  • frontend/pages/admin/IntegrationsPage/cards/ChangeManagement/ChangeManagement.tsx

Walkthrough

This change addresses spacing issues in the GitOps exceptions section of the ChangeManagement integration page. A CSS class form-field is applied to the container div wrapping the exceptions checkboxes to add proper padding between them. A corresponding changelog entry documents this fix.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: updating a CSS class on the exceptions field to fix padding issues.
Description check ✅ Passed The description includes the related issue reference, checked the appropriate items in the template, provided testing confirmation, and included before/after visual evidence.
Linked Issues check ✅ Passed The PR changes comply with issue #43070 by applying the form-field class to provide proper padding between GitOps exceptions checkboxes per the design system.
Out of Scope Changes check ✅ Passed All changes are directly scoped to resolving issue #43070: a changes file entry and a CSS class update on the exceptions field container.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgress454/43070-fix-exceptions-spacing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the visual spacing/padding for the “Exceptions” checkbox area on the Change Management integrations card (resolves #43070).

Changes:

  • Adds the form-field class to the Exceptions field wrapper to align padding with other form fields.
  • Adds a user-visible change note for the padding fix.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/pages/admin/IntegrationsPage/cards/ChangeManagement/ChangeManagement.tsx Applies consistent form-field styling to the Exceptions wrapper to fix padding.
changes/43070-fix-exceptions-padding Adds a changelog entry noting the padding adjustment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.07%. Comparing base (5cc283c) to head (e23f596).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #43927    +/-   ##
========================================
  Coverage   65.07%   65.07%            
========================================
  Files        2603     2603            
  Lines      253207   253207            
  Branches     9355     9242   -113     
========================================
  Hits       164787   164787            
  Misses      75654    75654            
  Partials    12766    12766            
Flag Coverage Δ
frontend 54.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukeheath
lukeheath merged commit 75d8102 into main Apr 22, 2026
23 checks passed
@lukeheath
lukeheath deleted the sgress454/43070-fix-exceptions-spacing branch April 22, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps exceptions checkboxes have incorrect spacing

4 participants