Update go to 1.26.2 and update tooling to update it - #43771
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43771 +/- ##
========================================
Coverage 66.91% 66.91%
========================================
Files 2600 2600
Lines 208643 208978 +335
Branches 9228 9228
========================================
+ Hits 139608 139841 +233
- Misses 56326 56395 +69
- Partials 12709 12742 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request updates the Go toolchain from 1.26.1 to 1.26.2 across the repository. It updates the 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Go toolchain version to 1.26.2 (including Docker build images) and extends the make update-go tooling to cover more Go modules so future Go bumps are less manual.
Changes:
- Bump
godirective from1.26.1→1.26.2across several Go modules. - Update Golang base images (and pinned digests) in Dockerfiles used for desktop linux and tooling images.
- Expand
UPDATE_GO_MODSin theMakefilesomake update-goupdates more module files automatically.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/terraform/go.mod | Bump module go directive to 1.26.2 |
| tools/snapshot/go.mod | Bump module go directive to 1.26.2 |
| tools/qacheck/go.mod | Bump module go directive to 1.26.2 |
| tools/mdm/windows/bitlocker/go.mod | Bump module go directive to 1.26.2 |
| tools/mdm/migration/mdmproxy/Dockerfile | Update golang image to 1.26.2 (pinned digest) |
| tools/github-manage/go.mod | Bump module go directive to 1.26.2 |
| tools/ci/setboolcheck/go.mod | Bump module go directive to 1.26.2 |
| third_party/vuln-check/go.mod | Bump module go directive to 1.26.2 |
| orbit/changes/update-go-1.26.2 | Add Orbit release-note entry for Go bump |
| infrastructure/loadtesting/terraform/docker/loadtest.Dockerfile | Update golang image to 1.26.2 (pinned digest) |
| go.mod | Bump main module go directive to 1.26.2 |
| changes/update-go-1.26.2 | Add release-note entry for Go bump |
| Makefile | Expand UPDATE_GO_MODS list used by make update-go |
| Dockerfile-desktop-linux | Update golang image to 1.26.2 (pinned digest) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
|
Test failure seems a flaky unrelated test. Merging. |
Golang 1.26.2 has been released. It fixes some CVEs: https://github.com/golang/go/issues?q=milestone%3AGo1.26.2+label%3ACherryPickApproved
Summary by CodeRabbit