Update Fleet-maintained apps - #43749
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR updates maintained app metadata for eight applications and their platform variants in the Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ee/maintained-apps/outputs/iina/darwin.json`:
- Around line 9-12: The manifest uses only bundle_short_version ('1.4.2') which
will treat any 1.4.2 build as patched; update the Darwin manifest to perform
build-aware detection by adding a check against the bundle version/build
(CFBundleVersion) in addition to bundle_short_version so only machines with
CFBundleVersion matching the build in installer_url (build164) are considered
patched; locate the fields installer_url and sha256 and add or set the
corresponding bundle_version (or bundle_build) matcher to the exact build number
(164) used in IINA.v1.4.2-build164.dmg and ensure the query logic that
references bundle_short_version also checks this new bundle_version field.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a53bf159-4e1e-4a2e-b9f5-05d28690ed32
📒 Files selected for processing (8)
ee/maintained-apps/outputs/coteditor/darwin.jsonee/maintained-apps/outputs/gimp/darwin.jsonee/maintained-apps/outputs/gimp/windows.jsonee/maintained-apps/outputs/iina/darwin.jsonee/maintained-apps/outputs/orbstack/darwin.jsonee/maintained-apps/outputs/postman/darwin.jsonee/maintained-apps/outputs/postman/windows.jsonee/maintained-apps/outputs/rapidapi/darwin.json
| "installer_url": "https://dl-portal.iina.io/IINA.v1.4.2-build164.dmg", | ||
| "install_script_ref": "18ab90f9", | ||
| "uninstall_script_ref": "20f465cb", | ||
| "sha256": "2e0fd89fbba1c92a6c115171e5b51904883bb497fbe513a6961d080fbab08ff6", | ||
| "sha256": "804e3368518f19039ebfbc3d698e1fabc9cd20f15fc4e42de635456cdf6a7f58", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether Fleet manifests or schema support build-aware detection for macOS apps.
# 1) Check if iina manifest has any build-aware query patterns beyond bundle_short_version.
rg -n -C3 --iglob '*iina*darwin.json' 'patched|bundle_short_version|bundle_version|build'
# 2) Look for maintained app manifests that use bundle_version (or similar) in patched queries.
rg -n -C2 'version_compare\(bundle_version|bundle_version|build' ee/maintained-apps/outputs
# 3) Inspect app inventory columns referenced by maintained app SQL queries.
rg -n -C3 'CREATE TABLE apps|bundle_short_version|bundle_version' server eeRepository: fleetdm/fleet
Length of output: 50536
Build-level detection not supported in patch query; version-only comparison creates upgrade risk.
The patched query uses bundle_short_version = '1.4.2' only. Since IINA.v1.4.2-build164.dmg specifies a particular build, any machine with an older 1.4.2 build will be marked as patched and not offered the upgrade to build164. All examined maintained app manifests on Darwin follow this pattern, with no build-aware detection in use.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ee/maintained-apps/outputs/iina/darwin.json` around lines 9 - 12, The
manifest uses only bundle_short_version ('1.4.2') which will treat any 1.4.2
build as patched; update the Darwin manifest to perform build-aware detection by
adding a check against the bundle version/build (CFBundleVersion) in addition to
bundle_short_version so only machines with CFBundleVersion matching the build in
installer_url (build164) are considered patched; locate the fields installer_url
and sha256 and add or set the corresponding bundle_version (or bundle_build)
matcher to the exact build number (164) used in IINA.v1.4.2-build164.dmg and
ensure the query logic that references bundle_short_version also checks this new
bundle_version field.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit