Update Fleet-maintained apps - #43567
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughUpdated version metadata for three maintained applications in JSON configuration files: Claude Desktop macOS (1.2278.0 → 1.2581.0), Connect Fonts (28.1.0 → 28.1.1), and Dropbox macOS (246.4.3513 → 248.4.3576). For each application, the corresponding version field, patched SQL logic comparison threshold, installer URL filename, and SHA256 checksum were updated to match the new release artifacts. Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ee/maintained-apps/outputs/claude/darwin.json (1)
12-12: Checksum field is updated, but installer integrity is still not enforced downstream.Line 12 is correct in this manifest, but Fleet’s downloader path currently does not verify downloaded content against
sha256, so this protection is metadata-only right now. Consider adding checksum validation in the installer download/apply flow.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ee/maintained-apps/outputs/claude/darwin.json` at line 12, The manifest’s "sha256" field is present but never enforced downstream; add checksum verification to the installer download/apply flow by fetching the expected "sha256" from the manifest and computing the SHA-256 of the downloaded installer, then compare and abort on mismatch. Implement a helper like verifyInstallerChecksum(downloadedBytes, expectedSha256) and call it from the downloader function (e.g., downloadInstaller) before calling applyInstaller or any install/apply step, logging and failing the operation when the computed checksum != manifest "sha256".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ee/maintained-apps/outputs/claude/darwin.json`:
- Line 12: The manifest’s "sha256" field is present but never enforced
downstream; add checksum verification to the installer download/apply flow by
fetching the expected "sha256" from the manifest and computing the SHA-256 of
the downloaded installer, then compare and abort on mismatch. Implement a helper
like verifyInstallerChecksum(downloadedBytes, expectedSha256) and call it from
the downloader function (e.g., downloadInstaller) before calling applyInstaller
or any install/apply step, logging and failing the operation when the computed
checksum != manifest "sha256".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ce49b401-c64d-44d6-ac5b-bd96ae25f6aa
📒 Files selected for processing (3)
ee/maintained-apps/outputs/claude/darwin.jsonee/maintained-apps/outputs/connect-fonts/darwin.jsonee/maintained-apps/outputs/dropbox/darwin.json
|
Closing in favor of #43579. |
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit