Skip to content

gitops now processes Android certificates before Android profiles - #43080

Merged
getvictor merged 3 commits into
victor/42405-android-oncfrom
victor/42405-android-onc-gitops
Apr 7, 2026
Merged

gitops now processes Android certificates before Android profiles#43080
getvictor merged 3 commits into
victor/42405-android-oncfrom
victor/42405-android-onc-gitops

Conversation

@getvictor

@getvictor getvictor commented Apr 6, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #42405

Also, fixed bug with this edge case: Certificate removed while ONC profile is withheld

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.85%. Comparing base (e97d423) to head (f9d95d8).
⚠️ Report is 103 commits behind head on victor/42405-android-onc.

Files with missing lines Patch % Lines
...rver/datastore/mysql/host_certificate_templates.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           victor/42405-android-onc   #43080   +/-   ##
=========================================================
  Coverage                     66.85%   66.85%           
=========================================================
  Files                          2580     2580           
  Lines                        206993   206990    -3     
  Branches                       9277     9277           
=========================================================
- Hits                         138381   138380    -1     
+ Misses                        56033    56031    -2     
  Partials                      12579    12579           
Flag Coverage Δ
backend 68.63% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor getvictor linked an issue Apr 6, 2026 that may be closed by this pull request
32 tasks
@getvictor
getvictor marked this pull request as ready for review April 7, 2026 18:31
@getvictor
getvictor requested a review from a team as a code owner April 7, 2026 18:31

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@getvictor
getvictor merged commit e80a0a1 into victor/42405-android-onc Apr 7, 2026
48 checks passed
@getvictor
getvictor deleted the victor/42405-android-onc-gitops branch April 7, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: deploy Wi-Fi configuration profile after certificate is deployed

1 participant