Skip to content

Cherry-pick #40586: Support report/fleet as spec "kinds" - #40632

Merged
sgress454 merged 1 commit into
rc-minor-fleet-v4.82.0from
cherry-pick-40586
Feb 26, 2026
Merged

Cherry-pick #40586: Support report/fleet as spec "kinds"#40632
sgress454 merged 1 commit into
rc-minor-fleet-v4.82.0from
cherry-pick-40586

Conversation

@sgress454

Copy link
Copy Markdown
Contributor

Cherry-pick of #40586 into rc-minor-fleet-v4.82.0.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** For #39314 
**Related issue:** For #39238  

# Details

This PR allows the use of "fleet" and "report" as spec "kinds",
deprecating the use of "team" and "query".

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
n/a

## Testing

- [X] Added/updated automated tests
- [X] QA'd all new/changed functionality manually

Deprecation logs assume `--enable-log-topics=deprecated-field-names` is
used in the command

- [ ] `fleetctl apply -f /path/to/spec` should add/update a fleet when
used with a spec containing `kind: fleet`
- [ ] `fleetctl apply -f /path/to/spec` should add/update a report when
used with a spec containing `kind: report`
- [ ] `fleetctl apply -f /path/to/spec` should add/update a fleet when
used with a spec containing `kind: team`, and log a deprecation warning
- [ ] `fleetctl apply -f /path/to/spec` should add/update a report when
used with a spec containing `kind: query`, , and log a deprecation
warning
@sgress454
sgress454 merged commit 20cd27a into rc-minor-fleet-v4.82.0 Feb 26, 2026
37 checks passed
@sgress454
sgress454 deleted the cherry-pick-40586 branch February 26, 2026 19:29
@codecov

codecov Bot commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.82.0@eedc66a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/spec/spec.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.82.0   #40632   +/-   ##
=========================================================
  Coverage                          ?   66.40%           
=========================================================
  Files                             ?     2456           
  Lines                             ?   197023           
  Branches                          ?     8556           
=========================================================
  Hits                              ?   130837           
  Misses                            ?    54348           
  Partials                          ?    11838           
Flag Coverage Δ
backend 68.16% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants