Fix batch set installers not updating some fields - #40631
Merged
Conversation
Member
Author
|
I believe TestGetAssets failing is unrelated as it fails on |
jkatz01
marked this pull request as ready for review
February 26, 2026 19:46
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40631 +/- ##
=======================================
Coverage 66.28% 66.29%
=======================================
Files 2466 2466
Lines 197534 197570 +36
Branches 8601 8601
=======================================
+ Hits 130945 130987 +42
+ Misses 54740 54733 -7
- Partials 11849 11850 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jahzielv
approved these changes
Feb 26, 2026
jkatz01
added a commit
that referenced
this pull request
Feb 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #40549 Fix some settings like setup experience, self service, scripts, not being updated in BatchSetSoftwareInstallers ## Testing - [x] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually - Tested that unlocked version FMA setup experience, self service, or script changes appropriately - Tested with version locked FMA For unreleased bug fixes in a release candidate, one of: - [ ] Confirmed that the fix is not expected to adversely impact load test results - [ ] Alerted the release DRI if additional load testing is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #40549
Fix some settings like setup experience, self service, scripts, not being updated in BatchSetSoftwareInstallers
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
Tested that unlocked version FMA setup experience, self service, or script changes appropriately
Tested with version locked FMA
For unreleased bug fixes in a release candidate, one of: