Skip to content

Fix batch set installers not updating some fields - #40631

Merged
jkatz01 merged 4 commits into
mainfrom
40549-batch-installer-fix
Feb 26, 2026
Merged

Fix batch set installers not updating some fields#40631
jkatz01 merged 4 commits into
mainfrom
40549-batch-installer-fix

Conversation

@jkatz01

@jkatz01 jkatz01 commented Feb 26, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #40549
Fix some settings like setup experience, self service, scripts, not being updated in BatchSetSoftwareInstallers

Testing

  • Added/updated automated tests

  • Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)

  • QA'd all new/changed functionality manually

  • Tested that unlocked version FMA setup experience, self service, or script changes appropriately

  • Tested with version locked FMA

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

@jkatz01

jkatz01 commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

I believe TestGetAssets failing is unrelated as it fails on main for me locally too.

@jkatz01
jkatz01 marked this pull request as ready for review February 26, 2026 19:46
@jkatz01
jkatz01 requested a review from a team as a code owner February 26, 2026 19:46
@codecov

codecov Bot commented Feb 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.29%. Comparing base (f555071) to head (f264cb1).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/software_installers.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40631   +/-   ##
=======================================
  Coverage   66.28%   66.29%           
=======================================
  Files        2466     2466           
  Lines      197534   197570   +36     
  Branches     8601     8601           
=======================================
+ Hits       130945   130987   +42     
+ Misses      54740    54733    -7     
- Partials    11849    11850    +1     
Flag Coverage Δ
backend 68.18% <92.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01
jkatz01 merged commit 7d567d7 into main Feb 26, 2026
43 of 46 checks passed
@jkatz01
jkatz01 deleted the 40549-batch-installer-fix branch February 26, 2026 20:27
jkatz01 added a commit that referenced this pull request Feb 26, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #40549 
Fix some settings like setup experience, self service, scripts, not
being updated in BatchSetSoftwareInstallers

## Testing

- [x] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually
- Tested that unlocked version FMA setup experience, self service, or
script changes appropriately
- Tested with version locked FMA

For unreleased bug fixes in a release candidate, one of:

- [ ] Confirmed that the fix is not expected to adversely impact load
test results
- [ ] Alerted the release DRI if additional load testing is needed
jkatz01 added a commit that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gitops: FMA installer with setup_experience swapped does not update state in Fleet

2 participants