improve windows resending - #40365
Merged
Merged
Conversation
MagnusHJensen
had a problem deploying
to
Docker Hub
February 23, 2026 23:50 — with 
GitHub Actions
Error
GitHub Actions
Error
MagnusHJensen
force-pushed
the
improve-windows-resending
branch
from
February 23, 2026 23:54
e56a250 to
1f51aa3
Compare
MagnusHJensen
had a problem deploying
to
Docker Hub
February 23, 2026 23:54 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40365 +/- ##
==========================================
- Coverage 66.27% 66.27% -0.01%
==========================================
Files 2459 2459
Lines 196694 197077 +383
Branches 8609 8609
==========================================
+ Hits 130364 130614 +250
- Misses 54516 54637 +121
- Partials 11814 11826 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JordanMontgomery
previously approved these changes
Feb 24, 2026
JordanMontgomery
left a comment
JordanMontgomery
left a comment
Member
There was a problem hiding this comment.
one question. Assuming we don't allow users to control the UUIDs on custom commands, LGTM
| if protoCMD.Cmd.Data != nil && *protoCMD.Cmd.Data == "418" { | ||
| if protoCMD.Cmd.Data != nil && *protoCMD.Cmd.Data == "418" && protoCMD.Cmd.CmdRef != nil { | ||
| if _, err := uuid.Parse(*protoCMD.Cmd.CmdRef); err != nil { | ||
| continue // if it's not a valid UUID, we skip it since it can't be a reference to a command_uuid in windows_mdm_commands |
Member
There was a problem hiding this comment.
If a user runs a custom command do we allow them to control the UUID?
MagnusHJensen
temporarily deployed
to
Docker Hub
February 24, 2026 01:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
JordanMontgomery
approved these changes
Feb 24, 2026
MagnusHJensen
added a commit
that referenced
this pull request
Feb 24, 2026
Improves windows resending
iansltx
pushed a commit
that referenced
this pull request
Feb 24, 2026
Cherry picks: #40365 into 4.82
Member
georgekarrv
pushed a commit
that referenced
this pull request
Feb 27, 2026
Improves windows resending
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves windows resending