Closed
Review and confirm test fix for MDM enrollment logging#39541
Conversation
3 tasks
fleet-release
approved these changes
Feb 8, 2026
Copilot
AI
changed the title
[WIP] Address feedback on gokit/log to slog transition changes
Review and confirm test fix for MDM enrollment logging
Feb 8, 2026
fleet-release
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the fix in
TestWindowsMDMEnrollEmptyBinarySecurityTokenwhere the test was incorrectly resettingfoundEnroll = falsein theMDE2EnrollPathcase, causing it to always pass even when an enroll request was unexpectedly logged.The fix correctly changes line 407 to
foundEnroll = true, ensuring the test properly detects unwanted enroll requests:With this fix,
require.False(t, foundEnroll)will now fail if an enroll request appears in the logs, as intended.Checklist for submitter
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.