Skip to content

Cherry pick: Fixed Android certificate enrollment failures caused by SCEP challenge expiration when devices were offline - #38932

Merged
mostlikelee merged 1 commit into
rc-minor-fleet-v4.80.0from
38753-cherry-pick
Jan 28, 2026
Merged

Cherry pick: Fixed Android certificate enrollment failures caused by SCEP challenge expiration when devices were offline#38932
mostlikelee merged 1 commit into
rc-minor-fleet-v4.80.0from
38753-cherry-pick

Conversation

@mostlikelee

Copy link
Copy Markdown
Contributor

ref: #38753

…e expiration when devices were offline. (#38753)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #37651

Switched to issue the SCEP fleet challenge on demand instead of ahead of
time.

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Resolved Android certificate enrollment failures caused by SCEP
challenge expiration during offline periods, improving enrollment
reliability when devices lack connectivity.

* **Improvements**
* Certificate challenges are now generated on-demand when requested by
devices, rather than pre-generated, enhancing offline enrollment
support.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@mostlikelee
mostlikelee requested a review from a team as a code owner January 28, 2026 17:51
@mostlikelee
mostlikelee merged commit d34a19e into rc-minor-fleet-v4.80.0 Jan 28, 2026
37 checks passed
@mostlikelee
mostlikelee deleted the 38753-cherry-pick branch January 28, 2026 18:07
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.80.0@c1736a9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rver/datastore/mysql/host_certificate_templates.go 80.00% 4 Missing and 4 partials ⚠️
server/service/certificates.go 66.66% 1 Missing and 1 partial ⚠️
server/mdm/android/service/service.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.80.0   #38932   +/-   ##
=========================================================
  Coverage                          ?   65.96%           
=========================================================
  Files                             ?     2396           
  Lines                             ?   191718           
  Branches                          ?     8443           
=========================================================
  Hits                              ?   126468           
  Misses                            ?    53719           
  Partials                          ?    11531           
Flag Coverage Δ
backend 67.80% <78.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants