Fixed false negative CVE for pgAdmin 4. - #38813
Conversation
| for _, cpeItem := range cpeItems { | ||
| if cpeItem.Vendor == "pgadmin" && | ||
| (cpeItem.Product == "pgadmin_4" || cpeItem.Product == "pgadmin" || cpeItem.Product == "pgadmin4") { | ||
| // Add aliases with product name variations and target_sw=postgresql | ||
| for _, productName := range []string{"pgadmin", "pgadmin_4", "pgadmin4"} { | ||
| newItem := *cpeItem | ||
| newItem.Product = productName | ||
| newItem.TargetSW = "postgresql" | ||
| cpeItems = append(cpeItems, &newItem) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is to make sure we match the CVE to our CPEs.
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
WalkthroughThis pull request adds vulnerability detection support for pgAdmin 4 by introducing a CPE translation entry and expanding CPE alias generation logic to correctly match NVD CVE records with pgAdmin installations, resolving a false negative for CVE-2025-13780. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38813 +/- ##
==========================================
+ Coverage 66.07% 66.11% +0.03%
==========================================
Files 2415 2420 +5
Lines 192800 193766 +966
Branches 8536 8536
==========================================
+ Hits 127399 128109 +710
- Misses 53832 54020 +188
- Partials 11569 11637 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #37957 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Bug Fixes * **Enhanced pgAdmin 4 vulnerability detection** – Improved the system's ability to identify pgAdmin 4-related vulnerabilities across multiple platforms and installation configurations, addressing previously undetected security issues. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Related issue: Resolves #37957
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.Testing
Summary by CodeRabbit
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.