Skip to content

ADR-0008: Migrate from go-kit/log to slog - #38751

Merged
lukeheath merged 5 commits into
mainfrom
adr-0008-slog
Jan 26, 2026
Merged

ADR-0008: Migrate from go-kit/log to slog#38751
lukeheath merged 5 commits into
mainfrom
adr-0008-slog

Conversation

@getvictor

@getvictor getvictor commented Jan 24, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #38607

See the new ADR.

Summary by CodeRabbit

  • Documentation
    • Added Architecture Decision Record (ADR-0008) documenting a logging infrastructure migration strategy with phased implementation plan.
    • Updated ADR reference index.

✏️ Tip: You can customize this high-level summary in your review settings.

@getvictor

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jan 24, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

@coderabbitai

coderabbitai Bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

A new Architecture Decision Record (ADR-0008) has been added documenting the planned migration strategy from go-kit/log to slog with OpenTelemetry integration, including context-aware logging phases and implementation details. The ADR index has been updated to include this new entry.

Changes

Cohort / File(s) Summary
ADR Documentation
docs/Contributing/adr/0008-migrate-to-slog.md
New ADR document outlining three-phase migration plan: Foundation (dependencies and logging package setup), Incremental migration (package-by-package logger replacement with context-aware logging), and Cleanup (adapter removal). Includes before/after code examples, output format considerations, and trade-offs.
ADR Index
docs/Contributing/adr/README.md
Index entry added for ADR-0008 linking to the new migration decision document.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested reviewers

  • dantecatalfamo
  • lukeheath
  • sharon-fdm
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and does not follow the template requirements. It lacks required checklists for changes files, testing, database migrations, and other important sections. Complete the PR description by filling in applicable checklist items and sections from the description template, or explicitly state which sections do not apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change in the PR, which is the introduction of a new ADR document for migrating from go-kit/log to slog.
Linked Issues check ✅ Passed The PR introduces ADR-0008 which serves as a blueprint for the three-part implementation plan outlined in issue #38607, covering trace context injection, OTEL log export, and documentation updates.
Out of Scope Changes check ✅ Passed All changes are scoped to documentation (ADR creation and index update) that directly supports the planning for issue #38607; no out-of-scope code changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch adr-0008-slog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@getvictor
getvictor marked this pull request as ready for review January 26, 2026 15:02
Copilot AI review requested due to automatic review settings January 26, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Architecture Decision Record documenting a planned migration from go-kit/log to Go’s log/slog, and links it from the ADR index.

Changes:

  • Added ADR-0008 describing the rationale, phased implementation plan, and tradeoffs of migrating to log/slog with OpenTelemetry correlation.
  • Updated the ADR index to include ADR-0008.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/Contributing/adr/README.md Adds ADR-0008 to the ADR index list.
docs/Contributing/adr/0008-migrate-to-slog.md Introduces ADR-0008 documenting the proposed logging migration plan.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/Contributing/adr/0008-migrate-to-slog.md
mna
mna previously approved these changes Jan 26, 2026

@mna mna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

jahzielv
jahzielv previously approved these changes Jan 26, 2026

@jahzielv jahzielv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! love moving to stdlib deps when we can 👍

lukeheath
lukeheath previously approved these changes Jan 26, 2026

@lukeheath lukeheath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getvictor Thanks for putting this together. This makes sense to me.

Comment thread docs/Contributing/adr/0008-migrate-to-slog.md Outdated
@lukeheath
lukeheath dismissed stale reviews from jahzielv and mna via 69a0fdf January 26, 2026 21:50
@lukeheath
lukeheath merged commit 83624c0 into main Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export logs to OTEL

5 participants