Activity bounded context: Complete read operations - #38555
Merged
Conversation
…actor activity streaming to use ListActivities service with system-based authorization. Improve test coverage for cron activities.
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #38555 +/- ##
==========================================
+ Coverage 64.35% 64.39% +0.03%
==========================================
Files 2397 2398 +1
Lines 187216 187404 +188
Branches 8423 8559 +136
==========================================
+ Hits 120489 120672 +183
Misses 55817 55817
- Partials 10910 10915 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolve merge conflicts: - Keep branch's StreamActivities approach instead of main's cronActivitiesStreaming - Keep branch's HostProvider and GetHostLite additions to activity service - Remove main's MarkActivitiesAsStreamed from fleet.Datastore (now handled by activity service) - Remove main's testListHostPastActivities and cronActivitiesStreaming tests (not applicable to branch approach)
Member
Author
|
@coderabbitai full review |
getvictor
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JordanMontgomery
approved these changes
Feb 6, 2026
JordanMontgomery
left a comment
JordanMontgomery
left a comment
Member
There was a problem hiding this comment.
Changes look good to me
cdcme
approved these changes
Feb 9, 2026
lucasmrod
approved these changes
Feb 9, 2026
3 tasks
Merged
5 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #38534
moved
/api/_version_/fleet/hosts/{id:[0-9]+}/activitiesendpoint andMarkActivitiesAsStreamedto activity bounded contextChecklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
Summary by CodeRabbit
New Features
Refactor