Remove redundant label validation in BatchValidateLabels

[Copilot]

BatchValidateLabels was calling verifyLabelsToAssociate, which fails when authz.UserFromContext returns nil. This broke tests using the authorization context pattern (authz_ctx.SetChecked()) without a viewer context.

The call was redundant - BatchValidateLabels already validates label existence and accessibility via LabelIDsByName with a TeamFilter on line 810.

Changes:

• Removed verifyLabelsToAssociate call from BatchValidateLabels (lines 822-824 in server/service/labels.go)

Checklist for submitter

• Added/updated automated tests
• QA'd all new/changed functionality manually

Testing

Existing tests TestBatchValidateLabels and TestValidateSoftwareLabels now pass. Full service test suite passes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• example.com
  • Triggering command: /tmp/go-build3525966261/b001/service.test /tmp/go-build3525966261/b001/service.test -test.testlogfile=/tmp/go-build3525966261/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=Test.* .cfg ux-amd64/pkg/tool/linux_amd64/vet -p ws-sdk-go-v2/int-atomic mpile ux-amd64/pkg/too-buildtags -o 9329512/b1175/_p-errorsas mpile 0.1-go1.25.5.lin-nilfunc -p github.com/open-test t 0.1-go1.25.5.lin./server/service (dns block)
  • Triggering command: /tmp/go-build327650879/b001/service.test /tmp/go-build327650879/b001/service.test -test.testlogfile=/tmp/go-build327650879/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 9329512/b1087/_p-errorsas .cfg ux-amd64/pkg/tool/linux_amd64/vet -p dm/fleet/v4/serv-F mpile cG14DVMI3GmR (dns block)
  • Triggering command: /tmp/go-build2908409442/b001/service.test /tmp/go-build2908409442/b001/service.test -test.testlogfile=/tmp/go-build2908409442/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true se 9329512/b223/vet.cfg 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -p github.com/micro-c t 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -uns�� til.go t rg/toolchain@v0.0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports t rg/toolchain@v0../server/service/software_title_icons_test.go (dns block)
• fleetdm.com
  • Triggering command: /tmp/go-build3525966261/b001/service.test /tmp/go-build3525966261/b001/service.test -test.testlogfile=/tmp/go-build3525966261/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=Test.* .cfg ux-amd64/pkg/tool/linux_amd64/vet -p ws-sdk-go-v2/int-atomic mpile ux-amd64/pkg/too-buildtags -o 9329512/b1175/_p-errorsas mpile 0.1-go1.25.5.lin-nilfunc -p github.com/open-test t 0.1-go1.25.5.lin./server/service (dns block)
  • Triggering command: /tmp/go-build327650879/b001/service.test /tmp/go-build327650879/b001/service.test -test.testlogfile=/tmp/go-build327650879/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 9329512/b1087/_p-errorsas .cfg ux-amd64/pkg/tool/linux_amd64/vet -p dm/fleet/v4/serv-F mpile cG14DVMI3GmR (dns block)
  • Triggering command: /tmp/go-build2908409442/b001/service.test /tmp/go-build2908409442/b001/service.test -test.testlogfile=/tmp/go-build2908409442/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true se 9329512/b223/vet.cfg 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -p github.com/micro-c t 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -uns�� til.go t rg/toolchain@v0.0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports t rg/toolchain@v0../server/service/software_title_icons_test.go (dns block)
• https://api.github.com/repos/fleetdm/fleet/actions/runs/20588132768/artifacts
  • Triggering command: /usr/bin/curl curl -s -H Accept: application/vnd.github.v3+json REDACTED (http block)
• vpp.itunes.apple.com
  • Triggering command: /tmp/go-build3525966261/b001/service.test /tmp/go-build3525966261/b001/service.test -test.testlogfile=/tmp/go-build3525966261/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=Test.* .cfg ux-amd64/pkg/tool/linux_amd64/vet -p ws-sdk-go-v2/int-atomic mpile ux-amd64/pkg/too-buildtags -o 9329512/b1175/_p-errorsas mpile 0.1-go1.25.5.lin-nilfunc -p github.com/open-test t 0.1-go1.25.5.lin./server/service (dns block)
  • Triggering command: /tmp/go-build327650879/b001/service.test /tmp/go-build327650879/b001/service.test -test.testlogfile=/tmp/go-build327650879/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 9329512/b1087/_p-errorsas .cfg ux-amd64/pkg/tool/linux_amd64/vet -p dm/fleet/v4/serv-F mpile cG14DVMI3GmR (dns block)
  • Triggering command: /tmp/go-build2908409442/b001/service.test /tmp/go-build2908409442/b001/service.test -test.testlogfile=/tmp/go-build2908409442/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true se 9329512/b223/vet.cfg 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -p github.com/micro-c t 0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -uns�� til.go t rg/toolchain@v0.0.1-go1.25.5.linux-amd64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports t rg/toolchain@v0../server/service/software_title_icons_test.go (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Reference: https://github.com/fleetdm/fleet/actions/runs/20588132768/job/59128168179

Which test failed and why?

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.61%. Comparing base (fdbe5bf) to head (f60d264).
⚠️ Report is 1 commits behind head on 36758-team-labels-feedback-be.

Additional details and impacted files

@@                        Coverage Diff                        @@
##           36758-team-labels-feedback-be   #37746      +/-   ##
=================================================================
- Coverage                          64.29%   59.61%   -4.69%     
=================================================================
  Files                               2363     2331      -32     
  Lines                             187537   180530    -7007     
  Branches                            8002     8002              
=================================================================
- Hits                              120575   107616   -12959     
- Misses                             55305    63093    +7788     
+ Partials                           11657     9821    -1836     

Flag	Coverage Δ
backend	60.54% <ø> (-5.36%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.