Skip to content

Fix Okta IdP signing cert. (#37078) - #37123

Merged
getvictor merged 1 commit into
rc-minor-fleet-v4.78.0from
victor/cherrypick-okta-signing-cert
Dec 11, 2025
Merged

Fix Okta IdP signing cert. (#37078)#37123
getvictor merged 1 commit into
rc-minor-fleet-v4.78.0from
victor/cherrypick-okta-signing-cert

Conversation

@getvictor

Copy link
Copy Markdown
Member

Fixing unreleased Okta IdP signing cert issue which prevented from setting up Okta conditional access.

Testing

  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

Summary by CodeRabbit

  • New Features

  • Enhanced the IdP signing certificate download feature with an interactive button that provides real-time loading indicators and improved error handling. Users now receive immediate feedback during the download process with helpful error messages if any issues occur.

  • Chores

    • Removed unused import references.

✏️ Tip: You can customize this high-level summary in your review settings.


(cherry picked from commit 0c2d465)

Fixing unreleased Okta IdP signing cert issue which prevented from
setting up Okta conditional access.

## Testing

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Enhanced the IdP signing certificate download feature with an
interactive button that provides real-time loading indicators and
improved error handling. Users now receive immediate feedback during the
download process with helpful error messages if any issues occur.

* **Chores**
  * Removed unused import references.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: jacobshandling <61553566+jacobshandling@users.noreply.github.com>
(cherry picked from commit 0c2d465)
@getvictor
getvictor marked this pull request as ready for review December 11, 2025 15:21
@getvictor
getvictor requested a review from a team as a code owner December 11, 2025 15:21
@codecov

codecov Bot commented Dec 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.78.0@32a51df). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ditionalAccessModal/OktaConditionalAccessModal.tsx 14.28% 12 Missing ⚠️
frontend/services/entities/conditional_access.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.78.0   #37123   +/-   ##
=========================================================
  Coverage                          ?   65.89%           
=========================================================
  Files                             ?     2250           
  Lines                             ?   183863           
  Branches                          ?     7609           
=========================================================
  Hits                              ?   121157           
  Misses                            ?    51644           
  Partials                          ?    11062           
Flag Coverage Δ
frontend 54.00% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor
getvictor merged commit 5c52717 into rc-minor-fleet-v4.78.0 Dec 11, 2025
14 checks passed
@getvictor
getvictor deleted the victor/cherrypick-okta-signing-cert branch December 11, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants