36693 Do not send Automatic ENrollment Profile to Apple when it hasn't actually changed - #36893
Merged
Conversation
JordanMontgomery
temporarily deployed
to
Docker Hub
December 8, 2025 16:25 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36893 +/- ##
==========================================
+ Coverage 65.89% 65.92% +0.03%
==========================================
Files 2250 2251 +1
Lines 183931 184311 +380
Branches 7610 7610
==========================================
+ Hits 121195 121501 +306
- Misses 51662 51705 +43
- Partials 11074 11105 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JordanMontgomery
temporarily deployed
to
Docker Hub
December 8, 2025 18:57 — with
GitHub Actions
Inactive
JordanMontgomery
marked this pull request as ready for review
December 10, 2025 18:03
MagnusHJensen
approved these changes
Dec 10, 2025
MagnusHJensen
left a comment
Member
There was a problem hiding this comment.
LGTM, skips if content is the same, but updates if it differs
gillespi314
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #36693
If a prior automatic enrollment(setup assistant) profile exists, compares it to the one being sent in the request and only revalidates it with Apple when it changes
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually