Skip to content

36693 Do not send Automatic ENrollment Profile to Apple when it hasn't actually changed - #36893

Merged
JordanMontgomery merged 3 commits into
mainfrom
JM-36693
Dec 10, 2025
Merged

36693 Do not send Automatic ENrollment Profile to Apple when it hasn't actually changed#36893
JordanMontgomery merged 3 commits into
mainfrom
JM-36693

Conversation

@JordanMontgomery

@JordanMontgomery JordanMontgomery commented Dec 8, 2025

Copy link
Copy Markdown
Member

Related issue: Resolves #36693

If a prior automatic enrollment(setup assistant) profile exists, compares it to the one being sent in the request and only revalidates it with Apple when it changes

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

@codecov

codecov Bot commented Dec 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.92%. Comparing base (0231c28) to head (9211415).
⚠️ Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/mdm.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36893      +/-   ##
==========================================
+ Coverage   65.89%   65.92%   +0.03%     
==========================================
  Files        2250     2251       +1     
  Lines      183931   184311     +380     
  Branches     7610     7610              
==========================================
+ Hits       121195   121501     +306     
- Misses      51662    51705      +43     
- Partials    11074    11105      +31     
Flag Coverage Δ
backend 67.71% <81.81%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JordanMontgomery JordanMontgomery changed the title Draft: 36693 Do not send Automatic ENrollment Profile to Apple when it hasn't actually changed 36693 Do not send Automatic ENrollment Profile to Apple when it hasn't actually changed Dec 10, 2025
@JordanMontgomery
JordanMontgomery marked this pull request as ready for review December 10, 2025 18:03
@JordanMontgomery
JordanMontgomery requested a review from a team as a code owner December 10, 2025 18:03

@MagnusHJensen MagnusHJensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, skips if content is the same, but updates if it differs

@JordanMontgomery
JordanMontgomery merged commit e9b8e47 into main Dec 10, 2025
48 checks passed
@JordanMontgomery
JordanMontgomery deleted the JM-36693 branch December 10, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps: "503 Service Unavailable" from Apple causes GitOps pipeline to fail

3 participants