Guarantee order of GetEnrollSecrets to prevent subtle bugs. - #36515
Merged
Merged
Conversation
Member
Author
|
This test is currently failing on main: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36515 +/- ##
==========================================
- Coverage 66.00% 59.33% -6.68%
==========================================
Files 2134 2133 -1
Lines 181857 181905 +48
Branches 7428 7428
==========================================
- Hits 120042 107935 -12107
- Misses 50827 63904 +13077
+ Partials 10988 10066 -922
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ksykulev
approved these changes
Dec 1, 2025
ksykulev
left a comment
Contributor
There was a problem hiding this comment.
subtle bugs indeed.
Confirmed, secret is the primary key
fleet/server/datastore/mysql/schema.sql
Line 405 in 56f01f0
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #36052
Checklist for submitter
Testing