Skip to content

Guarantee order of GetEnrollSecrets to prevent subtle bugs. - #36515

Merged
getvictor merged 1 commit into
mainfrom
victor/36052-enroll-secret
Dec 1, 2025
Merged

getvictor merged 1 commit into
mainfrom
victor/36052-enroll-secret

Conversation

@getvictor

Copy link
Copy Markdown
Member

Related issue: Resolves #36052

Checklist for submitter

Testing

  • QA'd all new/changed functionality manually

@getvictor getvictor mentioned this pull request Dec 1, 2025
7 tasks done
@getvictor
getvictor marked this pull request as ready for review December 1, 2025 20:26
@getvictor
getvictor requested a review from a team as a code owner December 1, 2025 20:26
@getvictor

Copy link
Copy Markdown
Member Author

This test is currently failing on main: FAIL: TestMaintainedApps/UpsertMaintainedApps

@codecov

codecov Bot commented Dec 1, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.33%. Comparing base (5303917) to head (bc145b1).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36515      +/-   ##
==========================================
- Coverage   66.00%   59.33%   -6.68%     
==========================================
  Files        2134     2133       -1     
  Lines      181857   181905      +48     
  Branches     7428     7428              
==========================================
- Hits       120042   107935   -12107     
- Misses      50827    63904   +13077     
+ Partials    10988    10066     -922     
Flag Coverage Δ
backend 59.97% <100.00%> (-7.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ksykulev ksykulev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle bugs indeed.
Confirmed, secret is the primary key

PRIMARY KEY (`secret`),

@getvictor
getvictor merged commit 20bac29 into main Dec 1, 2025
37 of 40 checks passed
@getvictor
getvictor deleted the victor/36052-enroll-secret branch December 1, 2025 22:20

This branch was previously deployed

1 inactive deployment
Docker Hub — bc145b1a Deployed Dec 1, 2025 by getvictor via publish #70518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android certs: non-critical issues

2 participants