Skip to content

make display name have patch semantics - #35947

Merged
jahzielv merged 3 commits into
mainfrom
34376-patch-semantics
Nov 19, 2025
Merged

make display name have patch semantics#35947
jahzielv merged 3 commits into
mainfrom
34376-patch-semantics

Conversation

@jahzielv

@jahzielv jahzielv commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Related issue: Resolves #35908

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

@jahzielv
jahzielv requested a review from a team as a code owner November 18, 2025 21:48
mna
mna previously approved these changes Nov 18, 2025
@mna

mna commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Oops looks like some tests are still using string instead of *string (CI failures).

@codecov

codecov Bot commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.23%. Comparing base (7ea2183) to head (f1a9997).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/in_house_apps.go 33.33% 1 Missing and 1 partial ⚠️
server/datastore/mysql/software_installers.go 33.33% 1 Missing and 1 partial ⚠️
server/datastore/mysql/vpp.go 33.33% 1 Missing and 1 partial ⚠️
server/service/vpp.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35947      +/-   ##
==========================================
+ Coverage   59.60%   66.23%   +6.63%     
==========================================
  Files        2109     2110       +1     
  Lines      179269   179363      +94     
  Branches     7385     7385              
==========================================
+ Hits       106848   118798   +11950     
+ Misses      62454    49666   -12788     
- Partials     9967    10899     +932     
Flag Coverage Δ
backend 67.90% <82.05%> (+7.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv

Copy link
Copy Markdown
Contributor Author

That's what I get for going straight to "ready for review"! 😮‍💨

@jahzielv
jahzielv merged commit 8a25886 into main Nov 19, 2025
43 checks passed
@jahzielv
jahzielv deleted the 34376-patch-semantics branch November 19, 2025 00:23
jahzielv added a commit that referenced this pull request Nov 19, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #35908 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
jahzielv added a commit that referenced this pull request Nov 19, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #35908 

cherry-pick for #35947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

display name editing doesn't follow PATCH semantics

3 participants