make display name have patch semantics - #35947
Merged
Merged
Conversation
mna
previously approved these changes
Nov 18, 2025
Contributor
|
Oops looks like some tests are still using |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35947 +/- ##
==========================================
+ Coverage 59.60% 66.23% +6.63%
==========================================
Files 2109 2110 +1
Lines 179269 179363 +94
Branches 7385 7385
==========================================
+ Hits 106848 118798 +11950
+ Misses 62454 49666 -12788
- Partials 9967 10899 +932
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
That's what I get for going straight to "ready for review"! 😮💨 |
jkatz01
approved these changes
Nov 19, 2025
jahzielv
added a commit
that referenced
this pull request
Nov 19, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #35908 # Checklist for submitter If some of the following don't apply, delete the relevant line. ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [x] Confirmed that the fix is not expected to adversely impact load test results
This was referenced Nov 19, 2025
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #35908
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
For unreleased bug fixes in a release candidate, one of: