Fix in-house apps allowing duplicates - #35854
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35854 +/- ##
==========================================
- Coverage 66.23% 66.23% -0.01%
==========================================
Files 2109 2109
Lines 179259 179259
Branches 7345 7345
==========================================
- Hits 118730 118724 -6
- Misses 49639 49643 +4
- Partials 10890 10892 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mna
approved these changes
Nov 17, 2025
jkatz01
added a commit
that referenced
this pull request
Nov 17, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #35758 Small fix for just 35758 so it can be cherry picked to 4.77, pulled from [this branch](https://github.com/fleetdm/fleet/tree/check-software-conflicts-iha-vpp-installers) that will fix more issues with duplicate checks across in-house, vpp, and software installers. # Checklist for submitter ## Testing - [x] Added/updated automated tests - [ ] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually - `.ipa` with the same bundle identifier but different name and version cannot be added anymore.
cdcme
pushed a commit
that referenced
this pull request
Nov 17, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #35758
Small fix for just 35758 so it can be cherry picked to 4.77, pulled from this branch that will fix more issues with duplicate checks across in-house, vpp, and software installers.
Checklist for submitter
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
.ipawith the same bundle identifier but different name and version cannot be added anymore.