Skip to content

Use full width on Setup experience config cards, fix width issue on Advanced options reveal button for bootstrap package config - #35698

Merged
iansltx merged 3 commits into
mainfrom
34530-style-fixes
Nov 14, 2025
Merged

Use full width on Setup experience config cards, fix width issue on Advanced options reveal button for bootstrap package config#35698
iansltx merged 3 commits into
mainfrom
34530-style-fixes

Conversation

@iansltx

@iansltx iansltx commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Fixes unreleased visual bugs in #34530.

image

Related issue: Resolves #

Checklist for submitter

Testing

  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

…dvanced options reveal button for bootstrap package config

Fixes unreleased visual bugs in #34530.
@iansltx
iansltx requested a review from a team as a code owner November 13, 2025 16:44
@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.20%. Comparing base (7a028d6) to head (6719b12).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...Page/SetupExperience/cards/RunScript/RunScript.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35698      +/-   ##
==========================================
- Coverage   66.24%   66.20%   -0.04%     
==========================================
  Files        2104     2104              
  Lines      178307   178365      +58     
  Branches     7424     7445      +21     
==========================================
- Hits       118122   118090      -32     
- Misses      49363    49453      +90     
  Partials    10822    10822              
Flag Coverage Δ
frontend 53.43% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jacobshandling
jacobshandling previously approved these changes Nov 13, 2025
@sgress454

Copy link
Copy Markdown
Contributor

I noticed a flicker when clicking the Run Script tab:

image

We're just missing a return here:

if (isLoading || isLoadingGlobalConfig || isLoadingTeamConfig) {
<Spinner />;
}

if you don't mind throwing that in...

@iansltx

iansltx commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Sure. Will ping you for review again once I've done so.

@iansltx
iansltx merged commit a638f18 into main Nov 14, 2025
15 checks passed
@iansltx
iansltx deleted the 34530-style-fixes branch November 14, 2025 05:21
iansltx added a commit that referenced this pull request Nov 14, 2025
…dvanced options reveal button for bootstrap package config (#35698)

Fixes unreleased visual bugs in #34530.

<img width="928" height="423" alt="image"
src="https://github.com/user-attachments/assets/8064005f-f9aa-445d-a058-e4ed333aacbc"
/>

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #

# Checklist for submitter

## Testing

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
iansltx added a commit that referenced this pull request Nov 14, 2025
…th issue on Advanced options reveal button for bootstrap package config (#35745)

Merged into `main` in #35698.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants