Skip to content

add support for in house apps and vpp apps - #35671

Merged
jahzielv merged 5 commits into
mainfrom
35534-missing-support
Nov 17, 2025
Merged

add support for in house apps and vpp apps#35671
jahzielv merged 5 commits into
mainfrom
35534-missing-support

Conversation

@jahzielv

@jahzielv jahzielv commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Related issue: Resolves #35534

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

@codecov

codecov Bot commented Nov 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.28%. Comparing base (33510dc) to head (7d4457e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/in_house_apps.go 33.33% 2 Missing and 2 partials ⚠️
server/datastore/mysql/software_installers.go 50.00% 1 Missing and 1 partial ⚠️
server/datastore/mysql/vpp.go 71.42% 1 Missing and 1 partial ⚠️
ee/server/service/in_house_apps.go 88.88% 0 Missing and 1 partial ⚠️
ee/server/service/software_installers.go 0.00% 0 Missing and 1 partial ⚠️
server/service/vpp.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35671      +/-   ##
==========================================
+ Coverage   66.23%   66.28%   +0.04%     
==========================================
  Files        2109     2107       -2     
  Lines      179221   178977     -244     
  Branches     7443     7343     -100     
==========================================
- Hits       118712   118634      -78     
+ Misses      49628    49458     -170     
- Partials    10881    10885       +4     
Flag Coverage Δ
backend 67.90% <73.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv
jahzielv marked this pull request as ready for review November 13, 2025 00:06
@jahzielv
jahzielv requested a review from a team as a code owner November 13, 2025 00:06

@jkatz01 jkatz01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jahzielv
jahzielv merged commit 67a9546 into main Nov 17, 2025
42 checks passed
@jahzielv
jahzielv deleted the 35534-missing-support branch November 17, 2025 16:23
jahzielv added a commit that referenced this pull request Nov 17, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #35534

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)

## Testing

- [x] Added/updated automated tests
- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
jahzielv added a commit that referenced this pull request Nov 17, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #35534

cherry-pick for #35671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting display name for VPP or .ipa files doesn't work

2 participants