Skip to content

Bugfix: Filter out in-house apps when listing software for setup experience - #35619

Merged
mna merged 2 commits into
rc-minor-fleet-v4.77.0from
mna-35167-prevent-ipa-setup-experience-for-rc
Nov 12, 2025
Merged

Bugfix: Filter out in-house apps when listing software for setup experience#35619
mna merged 2 commits into
rc-minor-fleet-v4.77.0from
mna-35167-prevent-ipa-setup-experience-for-rc

Conversation

@mna

@mna mna commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

Related issue: Resolves #35167

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

@mna

mna commented Nov 12, 2025

Copy link
Copy Markdown
Contributor Author

CI failure is unrelated, due to docker:

 redis01 Error Get "https://registry-1.docker.io/v2/": context deadline exceeded
Error response from daemon: Get "https://registry-1.docker.io/v2/": context deadline exceeded

    preview_test.go:31: 
        	Error Trace:	/home/runner/work/fleet/fleet/cmd/fleetctl/integrationtest/preview/preview_test.go:31
        	Error:      	Received unexpected error:
        	            	Failed to run `docker compose`
        	Test:       	TestIntegrationsPreview
Stopping services...
Fleet preview server and dependencies stopped. Start again with fleetctl preview.
    nettest.go:36: network test done: TestIntegrationsPreview
--- FAIL: TestIntegrationsPreview (22.77s)

@mna
mna marked this pull request as ready for review November 12, 2025 16:09
@mna
mna requested a review from a team as a code owner November 12, 2025 16:09
@codecov

codecov Bot commented Nov 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.77.0@04ee844). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.77.0   #35619   +/-   ##
=========================================================
  Coverage                          ?   66.14%           
=========================================================
  Files                             ?     2101           
  Lines                             ?   177503           
  Branches                          ?     7382           
=========================================================
  Hits                              ?   117413           
  Misses                            ?    49324           
  Partials                          ?    10766           
Flag Coverage Δ
backend 67.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mna
mna merged commit 600faea into rc-minor-fleet-v4.77.0 Nov 12, 2025
33 checks passed
@mna
mna deleted the mna-35167-prevent-ipa-setup-experience-for-rc branch November 12, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants