Fix [Object object] in script error display - #35476
Merged
Merged
Conversation
sgress454
commented
Nov 10, 2025
| className={`${baseClass}__status-message`} | ||
| iconName="error-outline" | ||
| message={`Error: ${message}`} | ||
| message={<>Error: {message}</>} |
Contributor
Author
There was a problem hiding this comment.
Since message can be a React element, concatenating it to a string results in [Object object]. Creating a wrapper React element allows us to add the Error: prefix safely whether message is a string or another React element (I tested w/ both).
jacobshandling
approved these changes
Nov 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35476 +/- ##
========================================
Coverage 66.13% 66.13%
========================================
Files 2100 2100
Lines 177475 177475
Branches 7398 7298 -100
========================================
Hits 117371 117371
Misses 49343 49343
Partials 10761 10761
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgress454
added a commit
that referenced
this pull request
Nov 11, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #35432 # Checklist for submitter ## Testing - [ ] Added/updated automated tests - [X] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [X] Confirmed that the fix is not expected to adversely impact load test results (cherry picked from commit 22fee0c)
sgress454
added a commit
that referenced
this pull request
Nov 11, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #35432
Checklist for submitter
Testing
For unreleased bug fixes in a release candidate, one of: