Fix issue where end-user sso form sometimes shows stale data - #35469
Merged
Conversation
sgress454
commented
Nov 10, 2025
Comment on lines
+65
to
+70
| // If there's no actual change, don't make the API call to update config. | ||
| // Still refetch in case settings were changed inside a card (like end-user auth). | ||
| if (Object.keys(diff).length === 0) { | ||
| refetchConfig(); | ||
| return true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This just prevents us from POSTing to the "update app config" API when there's nothing to update.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35469 +/- ##
==========================================
- Coverage 66.13% 66.13% -0.01%
==========================================
Files 2100 2100
Lines 177471 177477 +6
Branches 7396 7397 +1
==========================================
+ Hits 117372 117373 +1
- Misses 49337 49342 +5
Partials 10762 10762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
approved these changes
Nov 10, 2025
iansltx
left a comment
iansltx
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that this fixed the issue, and this looks like the right amount of code to do so, vs. what Copilot was throwing at me. Thanks so much!
sgress454
added a commit
that referenced
this pull request
Nov 10, 2025
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #35322 # Details Since the end-user auth form uses calls its own API rather than the common config update handler in the parent `IntegrationsPage`, we need to notify that parent when updates occur so that it can re-fetch the app config which serves as the base state for all of the sub-sections. # Checklist for submitter ## Testing - [ ] Added/updated automated tests - [X] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [X] Confirmed that the fix is not expected to adversely impact load test results (cherry picked from commit 63eb318)
sgress454
added a commit
that referenced
this pull request
Nov 10, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #35322
Details
Since the end-user auth form uses calls its own API rather than the common config update handler in the parent
IntegrationsPage, we need to notify that parent when updates occur so that it can re-fetch the app config which serves as the base state for all of the sub-sections.Checklist for submitter
Testing
For unreleased bug fixes in a release candidate, one of: