Skip to content

IHA: install verification - #34317

Merged
jahzielv merged 4 commits into
feat-in-house-appsfrom
33977-iha-verification
Oct 16, 2025
Merged

IHA: install verification#34317
jahzielv merged 4 commits into
feat-in-house-appsfrom
33977-iha-verification

Conversation

@jahzielv

@jahzielv jahzielv commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

closes #33977

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.01527% with 55 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat-in-house-apps@dc16c0d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/in_house_apps.go 59.42% 24 Missing and 4 partials ⚠️
server/service/apple_mdm.go 48.14% 7 Missing and 7 partials ⚠️
server/datastore/mysql/vpp.go 70.00% 5 Missing and 4 partials ⚠️
server/worker/vpp_verification.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat-in-house-apps   #34317   +/-   ##
=====================================================
  Coverage                      ?   64.24%           
=====================================================
  Files                         ?     2062           
  Lines                         ?   208033           
  Branches                      ?     6863           
=====================================================
  Hits                          ?   133660           
  Misses                        ?    63868           
  Partials                      ?    10505           
Flag Coverage Δ
backend 65.34% <58.01%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv
jahzielv marked this pull request as ready for review October 16, 2025 01:05
@jahzielv
jahzielv requested a review from a team as a code owner October 16, 2025 01:05

@cdcme cdcme left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for some minor things here. Overall, looks great!

Comment thread server/service/apple_mdm.go Outdated
Comment thread server/datastore/mysql/in_house_apps.go Outdated
Comment thread server/datastore/mysql/vpp.go Outdated
Comment thread server/datastore/mysql/vpp.go Outdated
Comment thread server/datastore/mysql/vpp.go
@jahzielv jahzielv linked an issue Oct 16, 2025 that may be closed by this pull request
@jahzielv jahzielv changed the title initial verification impl IHA: install verification Oct 16, 2025
@jahzielv
jahzielv merged commit d6b7883 into feat-in-house-apps Oct 16, 2025
39 checks passed
@jahzielv
jahzielv deleted the 33977-iha-verification branch October 16, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPA: verify install

2 participants