Skip to content

IPA: support in-house apps in list software/host software/filter hosts by install status - #34255

Merged
mna merged 8 commits into
feat-in-house-appsfrom
mna-34001-list-filter-ipa
Oct 20, 2025
Merged

IPA: support in-house apps in list software/host software/filter hosts by install status#34255
mna merged 8 commits into
feat-in-house-appsfrom
mna-34001-list-filter-ipa

Conversation

@mna

@mna mna commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Related issue: Partial #34001

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.53975% with 25 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat-in-house-apps@fa0b934). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/labels.go 47.61% 11 Missing ⚠️
server/datastore/mysql/hosts.go 72.72% 5 Missing and 1 partial ⚠️
server/datastore/mysql/software_installers.go 96.15% 5 Missing ⚠️
server/datastore/mysql/in_house_apps.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat-in-house-apps   #34255   +/-   ##
=====================================================
  Coverage                      ?   64.31%           
=====================================================
  Files                         ?     2064           
  Lines                         ?   208517           
  Branches                      ?     6825           
=====================================================
  Hits                          ?   134106           
  Misses                        ?    63882           
  Partials                      ?    10529           
Flag Coverage Δ
backend 65.41% <89.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mna
mna marked this pull request as ready for review October 15, 2025 19:57
@mna
mna requested a review from a team as a code owner October 15, 2025 19:57

@cdcme cdcme left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@mna
mna merged commit 6e2bba1 into feat-in-house-apps Oct 20, 2025
35 of 36 checks passed
@mna
mna deleted the mna-34001-list-filter-ipa branch October 20, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants