IHA: serve manifest and .ipa file from Fleet server - #34095
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-in-house-apps #34095 +/- ##
=====================================================
Coverage ? 64.14%
=====================================================
Files ? 2061
Lines ? 207793
Branches ? 6863
=====================================================
Hits ? 133287
Misses ? 64048
Partials ? 10458
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jahzielv
changed the title
mna
left a comment
mna
left a comment
There was a problem hiding this comment.
Sorry for the late review, LGTM just a note about the new endpoints!
| ne.POST("/api/fleet/orbit/enroll", enrollOrbitEndpoint, contract.EnrollOrbitRequest{}) | ||
|
|
||
| ne.GET("/api/_version_/fleet/software/titles/{title_id:[0-9]+}/in_house_app", getInHouseAppPackageEndpoint, getInHouseAppPackageRequest{}) | ||
| ne.GET("/api/_version_/fleet/software/titles/{title_id:[0-9]+}/in_house_app/manifest", getInHouseAppManifestEndpoint, getInHouseAppManifestRequest{}) |
There was a problem hiding this comment.
Just to make sure we follow-up on that, as it was not documented in the API changes, we should probably document those in the contributor API docs? And explain the authentication used?
There was a problem hiding this comment.
@mna yep, I think this should go in the contributor docs! Good callout.
3 participants
Fixes #33039
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
Added/updated automated tests
QA'd all new/changed functionality manually